From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel De Graaf Subject: Re: [PATCH 3/5] xen: sysctl XSM hook removal Date: Tue, 20 Nov 2012 10:34:47 -0500 Message-ID: <50ABA317.70300@tycho.nsa.gov> References: <50AA5521.6080907@tycho.nsa.gov> <1353423098-16371-1-git-send-email-dgdegra@tycho.nsa.gov> <1353423098-16371-4-git-send-email-dgdegra@tycho.nsa.gov> <50ABAF1302000078000AA0D5@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50ABAF1302000078000AA0D5@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: tim@xen.org, keir@xen.org, ian.campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 11/20/2012 10:25 AM, Jan Beulich wrote: >>>> On 20.11.12 at 15:51, Daniel De Graaf wrote: >> A number of the sysctl XSM hooks have no parameters or only pass the >> operation ID, making them redundant with the xsm_sysctl hook. Remove >> these redundant hooks. >> >> Signed-off-by: Daniel De Graaf >> --- >> xen/arch/x86/platform_hypercall.c | 12 ---- > > This is slightly confusing given the title/description. > > Jan > There were a few hooks used in both sysctl and platform_hypercall, so this was needed to avoid breaking the compile. I'll delay their removal until the next patch in order to keep the changes confined to a single file, which was my original goal. -- Daniel De Graaf National Security Agency