* [PATCH] README: add Pixman as build dependency @ 2012-11-23 12:51 Stefano Stabellini 2012-11-26 11:51 ` Roger Pau Monné 2012-11-27 14:15 ` Ian Campbell 0 siblings, 2 replies; 6+ messages in thread From: Stefano Stabellini @ 2012-11-23 12:51 UTC (permalink / raw) To: xen-devel; +Cc: Stefano Stabellini Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> diff --git a/README b/README index 21a81b2..88300df 100644 --- a/README +++ b/README @@ -51,6 +51,7 @@ provided by your OS distributor: * Development install of libaio (e.g. libaio-dev) version 0.3.107 or greater. Set CONFIG_SYSTEM_LIBAIO in .config if this is not available. * Development install of GLib v2.0 (e.g. libglib2.0-dev) + * Development install of Pixman (e.g. libpixman-1-dev) * pkg-config * bridge-utils package (/sbin/brctl) * iproute package (/sbin/ip) ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] README: add Pixman as build dependency 2012-11-23 12:51 [PATCH] README: add Pixman as build dependency Stefano Stabellini @ 2012-11-26 11:51 ` Roger Pau Monné 2012-11-26 19:35 ` Stefano Stabellini 2012-11-27 14:15 ` Ian Campbell 1 sibling, 1 reply; 6+ messages in thread From: Roger Pau Monné @ 2012-11-26 11:51 UTC (permalink / raw) To: Stefano Stabellini; +Cc: xen-devel@lists.xensource.com On 23/11/12 13:51, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > diff --git a/README b/README > index 21a81b2..88300df 100644 > --- a/README > +++ b/README > @@ -51,6 +51,7 @@ provided by your OS distributor: > * Development install of libaio (e.g. libaio-dev) version 0.3.107 or > greater. Set CONFIG_SYSTEM_LIBAIO in .config if this is not available. > * Development install of GLib v2.0 (e.g. libglib2.0-dev) > + * Development install of Pixman (e.g. libpixman-1-dev) Should we add a configure test for Pixman? I guess this is needed by Qemu. > * pkg-config > * bridge-utils package (/sbin/brctl) > * iproute package (/sbin/ip) > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] README: add Pixman as build dependency 2012-11-26 11:51 ` Roger Pau Monné @ 2012-11-26 19:35 ` Stefano Stabellini 2012-11-27 2:59 ` Matt Wilson 0 siblings, 1 reply; 6+ messages in thread From: Stefano Stabellini @ 2012-11-26 19:35 UTC (permalink / raw) To: Roger Pau Monne; +Cc: xen-devel@lists.xensource.com, Stefano Stabellini On Mon, 26 Nov 2012, Roger Pau Monne wrote: > On 23/11/12 13:51, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > > > diff --git a/README b/README > > index 21a81b2..88300df 100644 > > --- a/README > > +++ b/README > > @@ -51,6 +51,7 @@ provided by your OS distributor: > > * Development install of libaio (e.g. libaio-dev) version 0.3.107 or > > greater. Set CONFIG_SYSTEM_LIBAIO in .config if this is not available. > > * Development install of GLib v2.0 (e.g. libglib2.0-dev) > > + * Development install of Pixman (e.g. libpixman-1-dev) > > Should we add a configure test for Pixman? I guess this is needed by Qemu. Yes, it is a QEMU dependency. Is it actually a good idea to replicate all the configure checks done by QEMU's configure script in the Xen configure script? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] README: add Pixman as build dependency 2012-11-26 19:35 ` Stefano Stabellini @ 2012-11-27 2:59 ` Matt Wilson 2012-11-27 9:13 ` Ian Campbell 0 siblings, 1 reply; 6+ messages in thread From: Matt Wilson @ 2012-11-27 2:59 UTC (permalink / raw) To: Stefano Stabellini; +Cc: xen-devel@lists.xensource.com, Roger Pau Monne On Mon, Nov 26, 2012 at 07:35:43PM +0000, Stefano Stabellini wrote: > On Mon, 26 Nov 2012, Roger Pau Monne wrote: > > On 23/11/12 13:51, Stefano Stabellini wrote: > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > > > > > diff --git a/README b/README > > > index 21a81b2..88300df 100644 > > > --- a/README > > > +++ b/README > > > @@ -51,6 +51,7 @@ provided by your OS distributor: > > > * Development install of libaio (e.g. libaio-dev) version 0.3.107 or > > > greater. Set CONFIG_SYSTEM_LIBAIO in .config if this is not available. > > > * Development install of GLib v2.0 (e.g. libglib2.0-dev) > > > + * Development install of Pixman (e.g. libpixman-1-dev) > > > > Should we add a configure test for Pixman? I guess this is needed by Qemu. > > Yes, it is a QEMU dependency. > > Is it actually a good idea to replicate all the configure checks done by > QEMU's configure script in the Xen configure script? I don't think it's a good idea to duplicate checks. We should call qemu's ./configure early, perhaps from our ./configure, and make sure that errors are clearly propagated and messaged to the user. Matt ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] README: add Pixman as build dependency 2012-11-27 2:59 ` Matt Wilson @ 2012-11-27 9:13 ` Ian Campbell 0 siblings, 0 replies; 6+ messages in thread From: Ian Campbell @ 2012-11-27 9:13 UTC (permalink / raw) To: Matt Wilson Cc: xen-devel@lists.xensource.com, Roger Pau Monne, Stefano Stabellini On Tue, 2012-11-27 at 02:59 +0000, Matt Wilson wrote: > On Mon, Nov 26, 2012 at 07:35:43PM +0000, Stefano Stabellini wrote: > > On Mon, 26 Nov 2012, Roger Pau Monne wrote: > > > On 23/11/12 13:51, Stefano Stabellini wrote: > > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > > > > > > > diff --git a/README b/README > > > > index 21a81b2..88300df 100644 > > > > --- a/README > > > > +++ b/README > > > > @@ -51,6 +51,7 @@ provided by your OS distributor: > > > > * Development install of libaio (e.g. libaio-dev) version 0.3.107 or > > > > greater. Set CONFIG_SYSTEM_LIBAIO in .config if this is not available. > > > > * Development install of GLib v2.0 (e.g. libglib2.0-dev) > > > > + * Development install of Pixman (e.g. libpixman-1-dev) > > > > > > Should we add a configure test for Pixman? I guess this is needed by Qemu. > > > > Yes, it is a QEMU dependency. > > > > Is it actually a good idea to replicate all the configure checks done by > > QEMU's configure script in the Xen configure script? > > I don't think it's a good idea to duplicate checks. Ack. > We should call > qemu's ./configure early, perhaps from our ./configure, and Problem is that tools/qemu-blah/configure isn't available until it is cloned, which happens at build rather than configure time. > make sure > that errors are clearly propagated and messaged to the user. We should strive for this no matter when/where the qemu configure is run. So long as qemu's configure fails cleanly and we abort when that fails we should be in reasonable shape? Ian. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] README: add Pixman as build dependency 2012-11-23 12:51 [PATCH] README: add Pixman as build dependency Stefano Stabellini 2012-11-26 11:51 ` Roger Pau Monné @ 2012-11-27 14:15 ` Ian Campbell 1 sibling, 0 replies; 6+ messages in thread From: Ian Campbell @ 2012-11-27 14:15 UTC (permalink / raw) To: Stefano Stabellini; +Cc: xen-devel@lists.xensource.com On Fri, 2012-11-23 at 12:51 +0000, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Any build/error reporting improvements can be done separately IMHO, this patch is factually accurate in itself. Acked-by: Ian Campbell <ian.campbell@citrix.com> + applied. Ian ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-11-27 14:15 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-11-23 12:51 [PATCH] README: add Pixman as build dependency Stefano Stabellini 2012-11-26 11:51 ` Roger Pau Monné 2012-11-26 19:35 ` Stefano Stabellini 2012-11-27 2:59 ` Matt Wilson 2012-11-27 9:13 ` Ian Campbell 2012-11-27 14:15 ` Ian Campbell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).