Re: [PATCH] libxl: Make an internal function explicitly check existence of expected paths

[George Dunlap <george.dunlap@eu.citrix.com>]

On 27/11/12 11:44, Ian Campbell wrote:
> On Fri, 2012-11-23 at 15:56 +0000, George Dunlap wrote:
>> +        LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
>> +                   "Internal error: Missing xenstore node %s/removable", be_path);
>
> One or two of these new log lines are > 80 columns. You might find that
> using the shorthand LOG*() macros helps with this.

Oops -- I'll fix that up.

>
> Personally I don't think the "Internal error" tag is necessary either,
> but maybe a new return code ERROR_INTERNAL might make sense? or even an
> assert() if this is really a "libxl failed to maintain internal
> consistency" ?

The idea behind the "Internal" tag is to tell users, "Unless you've been 
manually messing around with xenstore removing nodes, this is definitely 
not your fault."

I guess normally an ASSERT communicates that pretty well, but I guess 
I'm used to ASSERTs that disappear when DEBUG is turned off. :-)  Is 
that not the case for libxl?

  -George