Re: [PATCH V4] X86/vMCE: handle broken page with regard to migration

[George Dunlap <george.dunlap@eu.citrix.com>]

On 05/12/12 15:57, Liu, Jinsong wrote:
> More simply, we can remove not only step #8 for last iteration check, but also the action to 'mark broken page to dirty bitmap':
> In any iteration, there is a key point #4, if vmce occur before #4 it will transfer proper pfn_type/pfn_number and (xl migration) will not access broken page (if guest access the broken page again it will be killed by hypervisor), if vmce occur after #4 system will crash and no need care migration any more.
>
> So we can go back to the original patch which used to handle 'vmce occur before migration' and entirely don't need add specific code to handle 'vmce occur during migration', since it in fact has handled both cases (and simple). Thoughts?

I thought part of the point of that was to have a consistent behavior 
from the presented virtual hardware -- i.e,. if the guest OS receives a 
vMCE, and subsequently touches that page, it should get an SRAR?  Is 
that important or not?

  -George