Re: [libvirt] [PATCH] Convert libxl driver to Xen 4.2

Re: [libvirt] [PATCH] Convert libxl driver to Xen 4.2

[Daniel P. Berrange]

On Tue, Nov 27, 2012 at 10:51:30AM +0000, Ian Campbell wrote:
> On Mon, 2012-11-26 at 22:28 +0000, Jim Fehlig wrote:
> > 
> > @@ -62,6 +63,52 @@ struct guest_arch {
> >  static const char *xen_cap_re = "(xen|hvm)-[[:digit:]]+\
> > \.[[:digit:]]+-(x86_32|x86_64|ia64|powerpc64)(p|be)?";
> >  static regex_t xen_cap_rec;
> > 
> > +/*
> > + * Copied from split_string_into_string_list() in
> > + * $xen-sources/tools/libxl/xl_cmdimpl.c, which is licensed LGPL v2.1.
> > + */
> 
> Looks like I am the sole author of that original function
> (24250:71ecbef5645f xen-unstable.hg). I'd more than likely be happy to
> relicence under whatever terms would be suitable for libvirt -- what are
> they?
> 
> In particular I'd be happy with LGPL v2.1+ if that's what it takes.

Yes, LGPL v2.1+ is what libvirt uses.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Re: [libvirt] [PATCH] Convert libxl driver to Xen 4.2

[Eric Blake]

[-- Attachment #1.1: Type: text/plain, Size: 1370 bytes --]

On 11/30/2012 03:13 PM, Jim Fehlig wrote:
> Based on a patch originally authored by Daniel De Graaf
> 
>   http://lists.xen.org/archives/html/xen-devel/2012-05/msg00565.html
> 
> This patch converts the Xen libxl driver to support only Xen >= 4.2.
> Support for Xen 4.1 libxl is dropped since that version of libxl is
> designated 'technology preview' only and is incompatible with Xen 4.2
> libxl.  Additionally, the default toolstack in Xen 4.1 is still xend,
> for which libvirt has a stable, functional driver.
> ---
> V2:
>   Remove 128 vcpu limit.
>   Remove split_string_into_string_list() function copied from xen
>   sources since libvirt now has virStringSplit().

Tested on Fedora 18, with its use of xen 4.2.  ACK; let's get this pushed.

> @@ -62,7 +64,6 @@ struct guest_arch {
>  static const char *xen_cap_re = "(xen|hvm)-[[:digit:]]+\\.[[:digit:]]+-(x86_32|x86_64|ia64|powerpc64)(p|be)?";
>  static regex_t xen_cap_rec;
>  
> -
>  static int
>  libxlNextFreeVncPort(libxlDriverPrivatePtr driver, int startPort)
>  {

This looks like a spurious whitespace change in isolation, but as long
as the overall file is consistent on one vs. two blank lines before
functions, I don't care if you keep or drop this hunk.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [libvirt] [PATCH] Convert libxl driver to Xen 4.2

[Jim Fehlig]

Eric Blake wrote:
> On 11/30/2012 03:13 PM, Jim Fehlig wrote:
>   
>> Based on a patch originally authored by Daniel De Graaf
>>
>>   http://lists.xen.org/archives/html/xen-devel/2012-05/msg00565.html
>>
>> This patch converts the Xen libxl driver to support only Xen >= 4.2.
>> Support for Xen 4.1 libxl is dropped since that version of libxl is
>> designated 'technology preview' only and is incompatible with Xen 4.2
>> libxl.  Additionally, the default toolstack in Xen 4.1 is still xend,
>> for which libvirt has a stable, functional driver.
>> ---
>> V2:
>>   Remove 128 vcpu limit.
>>   Remove split_string_into_string_list() function copied from xen
>>   sources since libvirt now has virStringSplit().
>>     
>
> Tested on Fedora 18, with its use of xen 4.2.  ACK; let's get this pushed.
>   

Thanks, pushed.

>   
>> @@ -62,7 +64,6 @@ struct guest_arch {
>>  static const char *xen_cap_re = "(xen|hvm)-[[:digit:]]+\\.[[:digit:]]+-(x86_32|x86_64|ia64|powerpc64)(p|be)?";
>>  static regex_t xen_cap_rec;
>>  
>> -
>>  static int
>>  libxlNextFreeVncPort(libxlDriverPrivatePtr driver, int startPort)
>>  {
>>     
>
> This looks like a spurious whitespace change in isolation, but as long
> as the overall file is consistent on one vs. two blank lines before
> functions, I don't care if you keep or drop this hunk.
>   

That was spurious, and removed before pushing.

Regards,
Jim

Re: [libvirt] [PATCH] Convert libxl driver to Xen 4.2

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 766 bytes --]

On Thu, 2012-12-06 at 16:20 -0700, Jim Fehlig wrote: 
> >> V2:
> >>   Remove 128 vcpu limit.
> >>   Remove split_string_into_string_list() function copied from xen
> >>   sources since libvirt now has virStringSplit().
> >>     
> >
> > Tested on Fedora 18, with its use of xen 4.2.  ACK; let's get this pushed.
> >   
> 
> Thanks, pushed.
> 
Cool!

(letting virt@lists.fedoraproject.org and xen@lists.fedoraproject.org
<xen@lists.fedoraproject.org> know about that!)

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Fedora-xen] [libvirt] [PATCH] Convert libxl driver to Xen 4.2

[Cole Robinson]

On 12/07/2012 11:18 AM, Dario Faggioli wrote:
> On Thu, 2012-12-06 at 16:20 -0700, Jim Fehlig wrote: 
>>>> V2:
>>>>   Remove 128 vcpu limit.
>>>>   Remove split_string_into_string_list() function copied from xen
>>>>   sources since libvirt now has virStringSplit().
>>>>     
>>>
>>> Tested on Fedora 18, with its use of xen 4.2.  ACK; let's get this pushed.
>>>   
>>
>> Thanks, pushed.
>>
> Cool!
> 
> (letting virt@lists.fedoraproject.org and xen@lists.fedoraproject.org
> <xen@lists.fedoraproject.org> know about that!)
> 

I pushed an F18 build yesterday, but it didn't contain the libxl patch since
it wasn't a trivial backport to 0.10.2 and I wanted to get a build out ASAP
since it was fixing a CVE. I'll take another stab at the libxl backport later
this week.

- Cole