From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH] x86/ucode: Improve error handling and container file processing on AMD Date: Fri, 7 Dec 2012 10:25:33 -0500 Message-ID: <50C20A6D.3010803@amd.com> References: <1354818491-9723-1-git-send-email-boris.ostrovsky@amd.com> <50C1E41402000078000AEED6@nat28.tlf.novell.com> <50C1F334.20802@amd.com> <50C2147C02000078000AEFCC@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50C2147C02000078000AEFCC@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian.Campbell@citrix.com, Christoph_Egger@gmx.de, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 12/07/2012 10:08 AM, Jan Beulich wrote: >>>> On 07.12.12 at 14:46, Boris Ostrovsky wrote: >> Do we really need what microcode_init() does? > > Oh yes, absolutely. How else would boot time microcode loading > work for secondary CPUs without this? Note that the notifier only > deals with the CPU_DEAD case. start_secondary() -> microcode_resume_cpu() -> microcode_ops->apply_microcode() will update non-boot CPUs in most cases. This won't quite work when secondary CPU is different from (or at different patch level than) boot CPU but that can be fixed. -boris