From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH 1/2] libxl: fix stale fd event callback race Date: Wed, 12 Dec 2012 10:20:11 -0700 Message-ID: <50C8BCCB.3000802@suse.com> References: <20678.5159.946248.90947@mariner.uk.xensource.com> <1355158624-11163-1-git-send-email-ian.jackson@eu.citrix.com> <50C7B518.9080503@suse.com> <20680.47369.582575.481507@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20680.47369.582575.481507@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xen.org" , Ian Campbell , Bamvor Jian Zhang List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > Jim Fehlig writes ("Re: [Xen-devel] [PATCH 1/2] libxl: fix stale fd event callback race"): > >> Thanks for the patches! I've found some time to test them in the context >> of Xen 4.2 and have some comments. For this patch, only a few nits below. >> > > Thanks for the review and testing. > > >>> - rc = OSEVENT_HOOK(fd_register, fd, &ev->for_app_reg, events, ev); >>> + rc = OSEVENT_HOOK(fd,register, alloc, fd, &ev->nexus->for_app_reg, >>> >>> >> Nit, should there be a space between 'fd,' and 'register'? >> > > I did this deliberately because the macro uses token pasting to turn > this into fd_register, at least in many of the uses. > Ok. > >>> Also, not that gcc complained, but register is a keyword. >>> > > The token "register" gets pasted together with other things by the > preprocessor before the compiler sees it, so it's correct as far as > the language spec goes. As for it being potentially confusing, > changing what appears here is difficult without changing the names > in libxl_osevent_hooks. > Yes, understood. Regards, Jim