xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Razvan Cojocaru <rzvncj@gmail.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Tim (Xen.org)" <tim@xen.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] libxc: Add xc_domain_hvm_get_mtrr_type() call
Date: Wed, 19 Dec 2012 14:00:58 +0200	[thread overview]
Message-ID: <50D1AC7A.70709@gmail.com> (raw)
In-Reply-To: <50D1A9D1.2020106@gmail.com>

>> xen/arch/x86/hvm/mtrr.c:mtrr_def_type_msr_set() seems to be where it is
>> written, and it is called with hw_mtrr.msr_mtrr_def_type so it looks
>> like it can be derived from that value in hvm_hw_mtrr.
>
> Indeed it is, but this happens there:
>
> uint8_t def_type = msr_content & 0xff;
> uint8_t enabled = (msr_content >> 10) & 0x3;

Nevermind, found it :)

mtrr.c / static int hvm_save_mtrr_msr(struct domain *d, 
hvm_domain_context_t *h):

hw_mtrr.msr_mtrr_def_type = mtrr_state->def_type
     | (mtrr_state->enabled << 10);

Thanks,
Razvan Cojocaru

  reply	other threads:[~2012-12-19 12:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 11:38 [PATCH] libxc: Add xc_domain_hvm_get_mtrr_type() call Razvan Cojocaru
2012-12-18 17:04 ` Ian Campbell
2012-12-18 17:24   ` Razvan Cojocaru
2012-12-19 10:14     ` Ian Campbell
2012-12-19 10:42       ` Razvan Cojocaru
2012-12-19 11:28         ` Ian Campbell
2012-12-19 11:49           ` Razvan Cojocaru
2012-12-19 12:00             ` Razvan Cojocaru [this message]
2012-12-19 14:57             ` Razvan Cojocaru
2012-12-19 15:00               ` Ian Campbell
2012-12-19 15:10                 ` Razvan Cojocaru
2012-12-19 15:27                 ` Andrew Cooper
2012-12-19 15:54                   ` Ian Campbell
2012-12-19 16:11                     ` Andrew Cooper
2012-12-19 16:15                       ` Ian Campbell
2012-12-19 16:29                         ` Razvan Cojocaru
2012-12-19 17:46                           ` Tim Deegan
2012-12-19 19:35                             ` Razvan Cojocaru
2012-12-20 11:57                               ` Tim Deegan
2012-12-20 13:40                                 ` Razvan Cojocaru
2012-12-19 15:43                 ` Razvan Cojocaru
2012-12-20 11:54               ` Tim Deegan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50D1AC7A.70709@gmail.com \
    --to=rzvncj@gmail.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).