From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rzvncj@gmail.com>
Subject: Re: [PATCH] libxc: Add xc_domain_hvm_get_mtrr_type()
 call
Date: Wed, 19 Dec 2012 14:00:58 +0200
Message-ID: <50D1AC7A.70709@gmail.com>
References: <a23515aabc91bec6e9cf.1355744310@rcojocaru.dsd.ro>
	<1355850255.14620.277.camel@zakaz.uk.xensource.com>
	<50D0A6B1.30702@gmail.com>
	<1355912063.14620.286.camel@zakaz.uk.xensource.com>
	<50D19A2B.2050006@gmail.com>
	<1355916539.14620.332.camel@zakaz.uk.xensource.com>
	<50D1A9D1.2020106@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <50D1A9D1.2020106@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Tim (Xen.org)" <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

>> xen/arch/x86/hvm/mtrr.c:mtrr_def_type_msr_set() seems to be where it is
>> written, and it is called with hw_mtrr.msr_mtrr_def_type so it looks
>> like it can be derived from that value in hvm_hw_mtrr.
>
> Indeed it is, but this happens there:
>
> uint8_t def_type = msr_content & 0xff;
> uint8_t enabled = (msr_content >> 10) & 0x3;

Nevermind, found it :)

mtrr.c / static int hvm_save_mtrr_msr(struct domain *d, 
hvm_domain_context_t *h):

hw_mtrr.msr_mtrr_def_type = mtrr_state->def_type
     | (mtrr_state->enabled << 10);

Thanks,
Razvan Cojocaru