From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 03 of 10 v2] xen: sched_credit: let the scheduler know about node-affinity Date: Thu, 20 Dec 2012 15:28:58 +0000 Message-ID: <50D32EBA.4020401@eu.citrix.com> References: <06d2f322a6319d8ba212.1355944039@Solace> <50D2B3DE.70206@ts.fujitsu.com> <1355991370.28419.15.camel@Abyss> <50D2CB96.4030509@ts.fujitsu.com> <1355992411.28419.25.camel@Abyss> <50D2CECB.4030108@ts.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50D2CECB.4030108@ts.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross Cc: Marcus Granado , Dan Magenheimer , Ian Campbell , Anil Madhavapeddy , Andrew Cooper , Dario Faggioli , Ian Jackson , "xen-devel@lists.xen.org" , Jan Beulich , Daniel De Graaf , Matt Wilson List-Id: xen-devel@lists.xenproject.org On 20/12/12 08:39, Juergen Gross wrote: > Am 20.12.2012 09:33, schrieb Dario Faggioli: >> On Thu, 2012-12-20 at 08:25 +0000, Juergen Gross wrote: >>>> BTW, can you be a little bit more specific about where you're suggesting >>>> to put it? I'm sorry but I'm not sure I figured what you mean by "the >>>> scheduler private per-pcpu area"... Do you perhaps mean making it a >>>> member of `struct csched_pcpu' ? >>> Yes, that's what I would suggest. >>> >> Ok then, functionally, that is going to be exactly the same thing as >> where it is right now, i.e., a set of global per_cpu() variables. It is >> possible for your solution to bring some cache/locality benefits, >> although that will very much depends on single cases, architecture, >> workload, etc. > The space is only allocated if sched_credit is responsible for the pcpu. That makes sense. -George