xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Wei Liu <liuw@liuw.name>, xen-devel@lists.xen.org
Subject: Re: [RFC PATCH 2/3] Dynamically allocate domain->evtchn, also bump EVTCHNS_PER_BUCKET to 512.
Date: Wed, 2 Jan 2013 13:38:25 +0000	[thread overview]
Message-ID: <50E43851.4080502@citrix.com> (raw)
In-Reply-To: <1356978155-18293-3-git-send-email-wei.liu2@citrix.com>

On 31/12/12 18:22, Wei Liu wrote:
> From: Wei Liu <liuw@liuw.name>

The changeset description needs to say why you're increasing
EVTCHNS_PER_BUCKET.  I can't tell why.

> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  xen/common/event_channel.c |    8 ++++++++
>  xen/include/xen/sched.h    |    4 ++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
> index 87e422e..9898f8e 100644
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1172,6 +1172,12 @@ void notify_via_xen_event_channel(struct domain *ld, int lport)
>  
>  int evtchn_init(struct domain *d)
>  {
> +    d->evtchn = (struct evtchn **)
> +        xzalloc_array(struct evtchn *, NR_EVTCHN_BUCKETS);

Don't need the cast here?

David

  reply	other threads:[~2013-01-02 13:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-31 18:22 Implement 3-level event channels in Xen Wei Liu
2012-12-31 18:22 ` [RFC PATCH 1/3] Add a field in struct domain to indicate evtchn level Wei Liu
2013-01-02 11:11   ` David Vrabel
2013-01-02 14:28     ` Wei Liu
2012-12-31 18:22 ` [RFC PATCH 2/3] Dynamically allocate domain->evtchn, also bump EVTCHNS_PER_BUCKET to 512 Wei Liu
2013-01-02 13:38   ` David Vrabel [this message]
2013-01-02 14:27     ` Wei Liu
2013-01-03 10:36       ` Jan Beulich
2013-01-03 11:33         ` Wei Liu
2013-01-03 11:39           ` Jan Beulich
2012-12-31 18:22 ` [RFC PATCH 3/3] Implement 3-level event channel routines Wei Liu
2013-01-02 14:08   ` David Vrabel
2013-01-02 16:45   ` Ian Campbell
2013-01-03 10:46     ` Jan Beulich
2013-01-03 11:35   ` Jan Beulich
2013-01-08 17:33     ` Wei Liu
2013-01-09  8:38       ` Jan Beulich
2013-01-09 10:56         ` Ian Campbell
2013-01-09 11:24           ` Jan Beulich
2013-01-09 11:31             ` Ian Campbell
2013-01-09 11:41               ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E43851.4080502@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=liuw@liuw.name \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).