From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [RFC PATCH 2/3] Dynamically allocate domain->evtchn, also bump EVTCHNS_PER_BUCKET to 512. Date: Wed, 2 Jan 2013 13:38:25 +0000 Message-ID: <50E43851.4080502@citrix.com> References: <1356978155-18293-1-git-send-email-wei.liu2@citrix.com> <1356978155-18293-3-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1356978155-18293-3-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 31/12/12 18:22, Wei Liu wrote: > From: Wei Liu The changeset description needs to say why you're increasing EVTCHNS_PER_BUCKET. I can't tell why. > Signed-off-by: Wei Liu > --- > xen/common/event_channel.c | 8 ++++++++ > xen/include/xen/sched.h | 4 ++-- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c > index 87e422e..9898f8e 100644 > --- a/xen/common/event_channel.c > +++ b/xen/common/event_channel.c > @@ -1172,6 +1172,12 @@ void notify_via_xen_event_channel(struct domain *ld, int lport) > > int evtchn_init(struct domain *d) > { > + d->evtchn = (struct evtchn **) > + xzalloc_array(struct evtchn *, NR_EVTCHN_BUCKETS); Don't need the cast here? David