From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH V2] mem_event: Add support for MEM_EVENT_REASON_MSR Date: Wed, 02 Jan 2013 16:40:28 +0200 Message-ID: <50E446DC.8060708@gmail.com> References: <1357133451.5668.23.camel@zakaz.uk.xensource.com> <50E43C7F.6000909@gmail.com> <1357137253.5668.49.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1357137253.5668.49.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xensource.com" , "Tim (Xen.org)" List-Id: xen-devel@lists.xenproject.org > That seems reasonable, thanks. Might be nice to include some of this > description in the changelog. No problem. I'll add that information to the changelog before re-submitting the patch. > Those names are #defines for the MSR address (see > xen/include/asm-x86/msr-index.h). > > "MSR address" or "MSR number" would be better than "MSR type" (which > implies to me membership of some sort of class of MSRs)` I'll change "MSR type" to "MSR address". Thank you for your comments, Razvan Cojocaru