From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH v4 00/04] HVM firmware passthrough Date: Thu, 3 Jan 2013 15:35:27 +0000 Message-ID: <50E5A53F.4050001@citrix.com> References: <831D55AF5A11D64C9B4B43F59EEBF720A31F6B645F@FTLPMAILBOX02.citrite.net> <20121221194533.GE30562@phenom.dumpdata.com> <831D55AF5A11D64C9B4B43F59EEBF720A31F6B65DA@FTLPMAILBOX02.citrite.net> <20121222021225.GA3468@phenom.dumpdata.com> <831D55AF5A11D64C9B4B43F59EEBF720A31F6B65F0@FTLPMAILBOX02.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <831D55AF5A11D64C9B4B43F59EEBF720A31F6B65F0@FTLPMAILBOX02.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ross Philipson Cc: "xen-devel@lists.xensource.com" , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org On 22/12/12 23:46, Ross Philipson wrote: > > In the process should I switch libxl to call xc_hvm_build() > rather than xc_hvm_build_target_mem()? Please. I'm not sure why I didn't do this when I introduced xc_hvm_build()... Note the units of the mem_size and mem_target fields are in bytes (not MiB like the old functions). David