From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] Passthough/domctl: Use correct struct in
 union
Date: Thu, 3 Jan 2013 21:51:25 +0000
Message-ID: <50E5FD5D.9010107@citrix.com>
References: <69ac79e96ddd501627f1.1357247263@andrewcoop.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <69ac79e96ddd501627f1.1357247263@andrewcoop.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "Keir (Xen.org)" <keir@xen.org>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 03/01/13 21:07, Andrew Cooper wrote:
> This appears to be a copy paste error from c/s 23861:ec7c81fbe0de.
>
> It is safe, functionally speaking, as both the xen_domctl_assign_device
> and xen_domctl_get_device_group structure start with a 'uint32_t
> machine_sbdf'.  We should however use the correct union structure.
>
> Signed-off-by: Andrew Cooper<andrew.cooper3@citrix.com>

I should also say that this affects Xen-4.2 as well, so I suggest it as 
a candidate for backport.

~Andrew

>
> diff -r c4114a042410 -r 69ac79e96ddd xen/drivers/passthrough/iommu.c
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -591,7 +591,7 @@ int iommu_do_domctl(
>           if ( ret )
>               break;
>
> -        seg = domctl->u.get_device_group.machine_sbdf>>  16;
> +        seg = domctl->u.assign_device.machine_sbdf>>  16;
>           bus = (domctl->u.assign_device.machine_sbdf>>  8)&  0xff;
>           devfn = domctl->u.assign_device.machine_sbdf&  0xff;
>
> @@ -615,7 +615,7 @@ int iommu_do_domctl(
>           if ( ret )
>               break;
>
> -        seg = domctl->u.get_device_group.machine_sbdf>>  16;
> +        seg = domctl->u.assign_device.machine_sbdf>>  16;
>           bus = (domctl->u.assign_device.machine_sbdf>>  8)&  0xff;
>           devfn = domctl->u.assign_device.machine_sbdf&  0xff;
>
> @@ -634,7 +634,7 @@ int iommu_do_domctl(
>           if ( ret )
>               break;
>
> -        seg = domctl->u.get_device_group.machine_sbdf>>  16;
> +        seg = domctl->u.assign_device.machine_sbdf>>  16;
>           bus = (domctl->u.assign_device.machine_sbdf>>  8)&  0xff;
>           devfn = domctl->u.assign_device.machine_sbdf&  0xff;
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel