From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Yongjie Ren <yongjie.ren@intel.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Konrad Wilk <konrad.wilk@oracle.com>,
Mats Petersson <mats.petersson@citrix.com>,
xen-devel <xen-devel@lists.xen.org>,
Chao Zhou <chao.zhou@intel.com>,
Andres Lagar-Cavilla <andreslc@gridcentric.ca>,
Yan Dai <yan.dai@intel.com>, YongweiX Xu <yongweix.xu@intel.com>,
Andres Lagar-Cavilla <andres.lagarcavilla@gmail.com>,
SongtaoX Liu <songtaox.liu@intel.com>,
AndresLagar-Cavilla <andres@lagarcavilla.org>
Subject: Re: VMX status report. Xen:26323 & Dom0:3.7.1
Date: Mon, 14 Jan 2013 16:15:46 +0000 [thread overview]
Message-ID: <50F42F32.9030003@citrix.com> (raw)
In-Reply-To: <50F43CFF02000078000B577F@nat28.tlf.novell.com>
On 14/01/13 16:14, Jan Beulich wrote:
>>>> On 14.01.13 at 17:03, David Vrabel <david.vrabel@citrix.com> wrote:
>> On 14/01/13 15:06, Andres Lagar-Cavilla wrote:
>>> @@ -288,7 +289,19 @@ static int mmap_batch_fn(void *data, void *state)
>>> &cur_page);
>>>
>>> /* Store error code for second pass. */
>>> - *(st->err++) = ret;
>>> + if (st->version == 1) {
>>> + if (ret < 0) {
>>> + /*
>>> + * V1 encodes the error codes in the 32bit top nibble of the
>>> + * mfn (with its known limitations vis-a-vis 64 bit callers).
>>> + */
>>> + *mfnp |= (ret == -ENOENT) ?
>>> + PRIVCMD_MMAPBATCH_PAGED_ERROR :
>>> + PRIVCMD_MMAPBATCH_MFN_ERROR;
>>
>> You also need to clear the top nibble on success (ret >= 0) so large
>> PFNs with the top nibble already set don't give false positives of errors.
>
> Not really - that's what v2 was added for (the caller, unless
> keeping a second array with the original MFNs, wouldn't be able
> to match things up in that case).
Ok, I can agree with that.
David
next prev parent reply other threads:[~2013-01-14 16:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 7:51 VMX status report. Xen:26323 & Dom0:3.7.1 Ren, Yongjie
2013-01-10 8:57 ` Jan Beulich
2013-01-10 17:10 ` Andres Lagar-Cavilla
2013-01-10 17:27 ` Mats Petersson
2013-01-11 8:34 ` Jan Beulich
2013-01-11 16:05 ` Andres Lagar-Cavilla
2013-01-14 4:29 ` Andres Lagar-Cavilla
2013-01-14 5:03 ` Andres Lagar-Cavilla
2013-01-14 13:59 ` David Vrabel
2013-01-14 15:06 ` Andres Lagar-Cavilla
2013-01-14 16:03 ` David Vrabel
2013-01-14 16:14 ` Jan Beulich
2013-01-14 16:15 ` David Vrabel [this message]
2013-01-14 16:19 ` Andres Lagar-Cavilla
2013-01-14 21:21 ` Konrad Rzeszutek Wilk
2013-01-14 16:18 ` Andres Lagar-Cavilla
2013-01-10 19:23 ` David Vrabel
2013-01-11 15:55 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F42F32.9030003@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=andres.lagarcavilla@gmail.com \
--cc=andres@lagarcavilla.org \
--cc=andreslc@gridcentric.ca \
--cc=chao.zhou@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=mats.petersson@citrix.com \
--cc=songtaox.liu@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yan.dai@intel.com \
--cc=yongjie.ren@intel.com \
--cc=yongweix.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).