From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH 1/4] tools: install under /usr/local by default. Date: Fri, 18 Jan 2013 16:19:49 +0100 Message-ID: <50F96815.1040405@citrix.com> References: <1358519119.3279.58.camel@zakaz.uk.xensource.com> <1358519140-20052-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1358519140-20052-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 18/01/13 15:25, Ian Campbell wrote: > This is the defacto (or FHS mandated?) standard location for software > built from source, in order to avoid clashing with packaged software > which is installed under /usr/bin etc. > = > I think there is benefit in having Xen's install behave more like the > majority of other OSS software out there. > = > The major downside here is in the transition from 4.2 to 4.3 where > people who have built from source will innevitably discover breakage > because 4.3 no longer overwrites stuff in /usr like it used to so they > pickup old stale bits from /usr instead of new stuff from /usr/local. > = > Packages will use ./configure --prefix=3D/usr or whatever helper macro > their package manager gives them. I have confirmed that doing this > results in the same list of installed files as before this patch was > applied. > = > Note that this does not currently affect docs or stubdoms at the > moment, so they still end up under /usr. There are proposals to use > configure here too at which point I would propose a similar patch and > these would also move as expected (depending on the sequencing I may > end folding that into this patch) I think the above paragraph is no longer true, you are modifying stubdoms configure to use the default prefix. Also the subject should be updated to "tools/stubdom:" or a similar prefix. > The hypervisor remains in /boot/ and there is no intention to move it. > = > Signed-off-by: Ian Campbell Apart from the above comment, the code itself looks right, so: Acked-by: Roger Pau Monn=E9