From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2] xenguest: Alter xsa-25 decompression limit prototypes Date: Mon, 28 Jan 2013 12:52:45 +0000 Message-ID: <5106749D.6080005@citrix.com> References: <75aafcd809a7352a95a5.1359373484@andrewcoop.uk.xensource.com> <1359373846.6559.67.camel@zakaz.uk.xensource.com> <51066795.5020306@citrix.com> <1359374741.6559.70.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1359374741.6559.70.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 28/01/13 12:05, Ian Campbell wrote: > On Mon, 2013-01-28 at 11:57 +0000, Andrew Cooper wrote: > >> The immediate preceeding function, xc_dom_linux_build returns a struct >> xc_dom_image * as its second parameter, > Does it? > > Looking at the only caller (the python bindings) I can see that the dom > paramter is an input parameter to that function and was previously > allocated via xc_dom_allocate. Looking at the implementation of > xc_domain_linux_build confirms this. > > Ian. > Ok - this is turning into far more of a rats nest than I originally thought. Please ignore the patch while I apply some sanity to our code. ~Andrew