Re: [PATCH 01/13] xen: fix output of xen_debug_interrupt

[David Vrabel <david.vrabel@citrix.com>]

On 31/01/13 14:46, Wei Liu wrote:
> Four things are fixed:
>  a) the test result of globaly masked event;
>  b) make the per-cpu selector L1 to be consistent with description in
>     __xen_evtchn_do_upcall's comment;
>  c) the test result of L1 selector;
>  d) add KERN_DEBUG in printk.

It's hard to pick out the correctness fixes with all the cosmetic
KERN_DEBUG fixes in the same patch.

> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  drivers/xen/events.c |   34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 7595581..2c94aad 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
[...]
> +			       !sync_test_bit(word_idx, &v->evtchn_pending_sel)
> +					     ? "" : " l1-clear",

This looks backwards now.

> +			       sync_test_bit(i, sh->evtchn_mask)
>  					     ? "" : " globally-masked",
>  			       sync_test_bit(i, cpu_evtchn)
>  					     ? "" : " locally-masked");

David