From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 01/13] xen: fix output of xen_debug_interrupt
Date: Fri, 1 Feb 2013 11:06:07 +0000
Message-ID: <510BA19F.6010900@citrix.com>
References: <1359643627-29486-1-git-send-email-wei.liu2@citrix.com>
	<1359643627-29486-2-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1359643627-29486-2-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>, Ian Campbell <Ian.Campbell@citrix.com>, "jbeulich@suse.com" <jbeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 31/01/13 14:46, Wei Liu wrote:
> Four things are fixed:
>  a) the test result of globaly masked event;
>  b) make the per-cpu selector L1 to be consistent with description in
>     __xen_evtchn_do_upcall's comment;
>  c) the test result of L1 selector;
>  d) add KERN_DEBUG in printk.

It's hard to pick out the correctness fixes with all the cosmetic
KERN_DEBUG fixes in the same patch.

> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  drivers/xen/events.c |   34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 7595581..2c94aad 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
[...]
> +			       !sync_test_bit(word_idx, &v->evtchn_pending_sel)
> +					     ? "" : " l1-clear",

This looks backwards now.

> +			       sync_test_bit(i, sh->evtchn_mask)
>  					     ? "" : " globally-masked",
>  			       sync_test_bit(i, cpu_evtchn)
>  					     ? "" : " locally-masked");

David