From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 12/13] xen: register 3-level event channel
Date: Fri, 1 Feb 2013 11:31:27 +0000
Message-ID: <510BA78F.1040204@citrix.com>
References: <1359643627-29486-1-git-send-email-wei.liu2@citrix.com>
	<1359643627-29486-13-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1359643627-29486-13-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>, Ian Campbell <Ian.Campbell@citrix.com>, "jbeulich@suse.com" <jbeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 31/01/13 14:47, Wei Liu wrote:
> 3-level event channel is registered in
>  a) xen_init_IRQ(), when the guest is fresh started;
>  b) xen_vcpu_restore(), when the guest is restored.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  arch/x86/xen/enlighten.c |   13 +++++++++++++
>  drivers/xen/events.c     |   11 ++++++++++-
>  2 files changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index bc893e7..919c7ed 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
[...]
> +
> +	rc = xen_event_channel_register_nlevel(3);
> +	if (!rc) {
> +		printk(KERN_INFO "Register 3-level event channel succeeded.\n");
> +		xen_set_event_channel_nlevel(3);
> +	} else {
> +		printk(KERN_INFO "Register 3-level event channel failed with %d.\n"
> +		       "Fall back to default 2-level event channel.\n",
> +		       rc);
> +		xen_set_event_channel_nlevel(2);
> +	}

You should have a function for this, instead of copy-and-paste in two
different places.

David