From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 05/13] xen: introduce test_and_set_mask Date: Fri, 1 Feb 2013 11:35:19 +0000 Message-ID: <510BA877.40200@citrix.com> References: <1359643627-29486-1-git-send-email-wei.liu2@citrix.com> <1359643627-29486-6-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1359643627-29486-6-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: "konrad.wilk@oracle.com" , Ian Campbell , "jbeulich@suse.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 31/01/13 14:46, Wei Liu wrote: > Signed-off-by: Wei Liu > --- > drivers/xen/events.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/xen/events.c b/drivers/xen/events.c > index 93a3648..0fae3f9 100644 > --- a/drivers/xen/events.c > +++ b/drivers/xen/events.c > @@ -345,6 +345,12 @@ static inline int test_evtchn(int port) > return sync_test_bit(port, &s->evtchn_pending[0]); > } > > +static inline int test_and_set_mask(int port) This name is too generic. Suggest test_and_set_evtchn_mask() or similar. David