From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH 1/2] xl/libxl: add netdev to vif specification Date: Tue, 5 Feb 2013 11:56:35 +0100 Message-ID: <5110E563.8030604@citrix.com> References: <1359127583-32490-1-git-send-email-roger.pau@citrix.com> <1359127583-32490-2-git-send-email-roger.pau@citrix.com> <1360060806.17017.25.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1360060806.17017.25.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ulf Kreutzberg , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org T24gMDUvMDIvMTMgMTE6NDAsIElhbiBDYW1wYmVsbCB3cm90ZToKPiBPbiBGcmksIDIwMTMtMDEt MjUgYXQgMTU6MjYgKzAwMDAsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPj4gVGhpcyBvcHRpb24g d2FzIHN1cHBvcnRlZCBpbiB0aGUgcGFzdCwgYWNjb3JkaW5nIHRvCj4+IGh0dHA6Ly93aWtpLnhl bi5vcmcvd2lraS9WaWYtcm91dGUsIHNvIHdlIHNob3VsZCBhbHNvIHN1cHBvcnQgaXQgaW4KPj4g bGlieGwuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBj aXRyaXguY29tPgo+PiBDYzogVWxmIEtyZXV0emJlcmcgPHVsZi5rcmV1dHpiZXJnQGhvc3RldXJv cGUuZGU+Cj4+IC0tLQo+PiAgZG9jcy9taXNjL3hsLW5ldHdvcmstY29uZmlndXJhdGlvbi5tYXJr ZG93biB8ICAgIDYgKysrKysrCj4+ICB0b29scy9saWJ4bC9saWJ4bC5jICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAgNiArKysrKy0KPj4gIHRvb2xzL2xpYnhsL2xpYnhsX2xpbnV4LmMgICAg ICAgICAgICAgICAgICAgfCAgICA5ICsrKysrKysrLQo+PiAgdG9vbHMvbGlieGwvbGlieGxfdHlw ZXMuaWRsICAgICAgICAgICAgICAgICB8ICAgIDEgKwo+PiAgdG9vbHMvbGlieGwveGxfY21kaW1w bC5jICAgICAgICAgICAgICAgICAgICB8ICAgIDUgKysrKysKPj4gIDUgZmlsZXMgY2hhbmdlZCwg MjUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RvY3Mv bWlzYy94bC1uZXR3b3JrLWNvbmZpZ3VyYXRpb24ubWFya2Rvd24gYi9kb2NzL21pc2MveGwtbmV0 d29yay1jb25maWd1cmF0aW9uLm1hcmtkb3duCj4+IGluZGV4IDVlMmYwNDkuLmI5OGIyOGUgMTAw NjQ0Cj4+IC0tLSBhL2RvY3MvbWlzYy94bC1uZXR3b3JrLWNvbmZpZ3VyYXRpb24ubWFya2Rvd24K Pj4gKysrIGIvZG9jcy9taXNjL3hsLW5ldHdvcmstY29uZmlndXJhdGlvbi5tYXJrZG93bgo+PiBA QCAtNjcsNiArNjcsMTIgQEAgYWRkZWQgdG8uIFRoZSBkZWZhdWx0IGlzIGB4ZW5icjBgLiBUaGUg YnJpZGdlIG11c3QgYmUgY29uZmlndXJlZCB1c2luZwo+PiAgeW91ciBkaXN0cmlidXRpb24ncyBu ZXR3b3JrIGNvbmZpZ3VyYXRpb24gdG9vbHMuIFNlZSB0aGUgW3dpa2ldW25ldF0KPj4gIGZvciBn dWlkYW5jZSBhbmQgZXhhbXBsZXMuCj4+ICAKPj4gKyMjIyBuZXRkZXYKPj4gKwo+PiArU3BlY2lm aWVzIHRoZSBuYW1lIG9mIHRoZSBuZXR3b3JrIGludGVyZmFjZSB3aGljaCBoYXMgYW4gSVAgYW5k IHdoaWNoCj4+ICtpcyBpbiB0aGUgbmV0d29yayB0aGUgVklGIHNob3VsZCBjb21tdW5pY2F0ZSB3 aXRoLgo+IAo+IEkgdGhpbmsgdGhpcyBuZWVkcyB0byBjbGFyaWZ5IHRoYXQgaXQgaXMgYSBob3N0 IG5ldHdvcmsgZGV2aWNlLgoKQWNrCgo+IAo+PiAgVGhpcyBpcyB1c2VkIGJ5IHRoZQo+PiArdmlm LXJvdXRlIGhvdHBsdWcgc2NyaXB0LiBTZWUgW3dpa2ldW3ZpZi1yb3V0ZV0gZm9yIGd1aWRhbmNl IGFuZCBleGFtcGxlcy4KPiAKPiBZb3UgbmVlZCB0byBhZGQgYSBVUkwgZm9yIHZpZi1yb3V0ZSBu ZWFyIHRoZSBib3R0b20gSSB0aGluay4KPiAKPj4gKwo+PiAgIyMjIHR5cGUKPj4gIAo+PiAgVGhp cyBrZXl3b3JkIGlzIHZhbGlkIGZvciBIVk0gZ3Vlc3RzIG9ubHkuCj4+IGRpZmYgLS1naXQgYS90 b29scy9saWJ4bC9saWJ4bC5jIGIvdG9vbHMvbGlieGwvbGlieGwuYwo+PiBpbmRleCA3M2UwZGMz Li4wM2JmZTFhIDEwMDY0NAo+PiAtLS0gYS90b29scy9saWJ4bC9saWJ4bC5jCj4+ICsrKyBiL3Rv b2xzL2xpYnhsL2xpYnhsLmMKPj4gQEAgLTI4MjYsNyArMjgyNiw3IEBAIHZvaWQgbGlieGxfX2Rl dmljZV9uaWNfYWRkKGxpYnhsX19lZ2MgKmVnYywgdWludDMyX3QgZG9taWQsCj4+ICAgICAgaWYg KHJjKSBnb3RvIG91dDsKPj4gIAo+PiAgICAgIGZyb250ID0gZmxleGFycmF5X21ha2UoZ2MsIDE2 LCAxKTsKPj4gLSAgICBiYWNrID0gZmxleGFycmF5X21ha2UoZ2MsIDE2LCAxKTsKPj4gKyAgICBi YWNrID0gZmxleGFycmF5X21ha2UoZ2MsIDE4LCAxKTsKPj4gIAo+PiAgICAgIGlmIChuaWMtPmRl dmlkID09IC0xKSB7Cj4+ICAgICAgICAgIGlmICgobmljLT5kZXZpZCA9IGxpYnhsX19kZXZpY2Vf bmV4dGlkKGdjLCBkb21pZCwgInZpZiIpIDwgMCkpIHsKPj4gQEAgLTI4NjIsNiArMjg2MiwxMCBA QCB2b2lkIGxpYnhsX19kZXZpY2VfbmljX2FkZChsaWJ4bF9fZWdjICplZ2MsIHVpbnQzMl90IGRv bWlkLAo+PiAgICAgICAgICBmbGV4YXJyYXlfYXBwZW5kKGJhY2ssICJpcCIpOwo+PiAgICAgICAg ICBmbGV4YXJyYXlfYXBwZW5kKGJhY2ssIGxpYnhsX19zdHJkdXAoZ2MsIG5pYy0+aXApKTsKPj4g ICAgICB9Cj4+ICsgICAgaWYgKG5pYy0+bmV0ZGV2KSB7Cj4+ICsgICAgICAgIGZsZXhhcnJheV9h cHBlbmQoYmFjaywgIm5ldGRldiIpOwo+PiArICAgICAgICBmbGV4YXJyYXlfYXBwZW5kKGJhY2ss IGxpYnhsX19zdHJkdXAoZ2MsIG5pYy0+bmV0ZGV2KSk7Cj4+ICsgICAgfQo+PiAgCj4+ICAgICAg aWYgKG5pYy0+cmF0ZV9pbnRlcnZhbF91c2VjcyA+IDApIHsKPj4gICAgICAgICAgZmxleGFycmF5 X2FwcGVuZChiYWNrLCAicmF0ZSIpOwo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGlieGxf bGludXguYyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2xpbnV4LmMKPj4gaW5kZXggMWZlZDNjZC4uNGNi ZGMxOSAxMDA2NDQKPj4gLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfbGludXguYwo+PiArKysgYi90 b29scy9saWJ4bC9saWJ4bF9saW51eC5jCj4+IEBAIC04NCwxMSArODQsMTYgQEAgc3RhdGljIGNo YXIgKipnZXRfaG90cGx1Z19lbnYobGlieGxfX2djICpnYywKPj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNoYXIgKnNjcmlwdCwgbGlieGxfX2RldmljZSAqZGV2KQo+PiAgewo+PiAg ICAgIGNvbnN0IGNoYXIgKnR5cGUgPSBsaWJ4bF9fZGV2aWNlX2tpbmRfdG9fc3RyaW5nKGRldi0+ YmFja2VuZF9raW5kKTsKPj4gKyAgICBjaGFyICpiZV9wYXRoID0gbGlieGxfX2RldmljZV9iYWNr ZW5kX3BhdGgoZ2MsIGRldik7Cj4+ICAgICAgY2hhciAqKmVudjsKPj4gKyAgICBjaGFyICpuZXRk ZXY7Cj4+ICAgICAgaW50IG5yID0gMDsKPj4gICAgICBsaWJ4bF9uaWNfdHlwZSBuaWN0eXBlOwo+ PiAgCj4+IC0gICAgY29uc3QgaW50IGFycmF5c2l6ZSA9IDEzOwo+PiArICAgIG5ldGRldiA9IGxp YnhsX194c19yZWFkKGdjLCBYQlRfTlVMTCwgR0NTUFJJTlRGKCIlcy8lcyIsIGJlX3BhdGgsCj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIm5ldGRldiIpKTsKPj4gKwo+PiArICAgIGNvbnN0IGludCBhcnJheXNpemUgPSAxNTsK Pj4gICAgICBHQ05FV19BUlJBWShlbnYsIGFycmF5c2l6ZSk7Cj4+ICAgICAgZW52W25yKytdID0g InNjcmlwdCI7Cj4+ICAgICAgZW52W25yKytdID0gc2NyaXB0Owo+PiBAQCAtOTgsNiArMTAzLDgg QEAgc3RhdGljIGNoYXIgKipnZXRfaG90cGx1Z19lbnYobGlieGxfX2djICpnYywKPj4gICAgICBl bnZbbnIrK10gPSBHQ1NQUklOVEYoImJhY2tlbmQvJXMvJXUvJWQiLCB0eXBlLCBkZXYtPmRvbWlk LCBkZXYtPmRldmlkKTsKPj4gICAgICBlbnZbbnIrK10gPSAiWEVOQlVTX0JBU0VfUEFUSCI7Cj4+ ICAgICAgZW52W25yKytdID0gImJhY2tlbmQiOwo+PiArICAgIGVudltucisrXSA9ICJuZXRkZXYi Owo+PiArICAgIGVudltucisrXSA9IG5ldGRldjsKPiAKPiBNaWdodG4ndCB0aGlzIGJlIE5VTEw/ CgpZZXMsIGlmIHdlIGFyZSB1c2luZyB0aGUgdmlmLWJyaWRnZSBzY3JpcHQgdGhpcyB3aWxsIGJl IE5VTEwsIGJ1dCBJCnByZWZlciBhZGRpbmcgdGhpcyBOVUxMIGhlcmUgcmF0aGVyIHRoYW4gaGF2 aW5nIGEgY29uZGl0aW9uYWwgYW5kIGEKdmFyaWFibGUgYXJyYXkgc2l6ZSAoYmVjYXVzZSB3ZSBh bHNvIGhhdmUgYW4gYXNzZXJ0KG5yID09IGFycmF5c2l6ZSkgYXQKdGhlIGVuZCBvZiB0aGUgY29k ZSBibG9jaykuCgo+IAo+PiAgICAgIGlmIChkZXYtPmJhY2tlbmRfa2luZCA9PSBMSUJYTF9fREVW SUNFX0tJTkRfVklGKSB7Cj4+ICAgICAgICAgIGlmIChsaWJ4bF9fbmljX3R5cGUoZ2MsIGRldiwg Jm5pY3R5cGUpKSB7Cj4+ICAgICAgICAgICAgICBMT0coRVJST1IsICJ1bmFibGUgdG8gZ2V0IG5p Y3R5cGUiKTsKPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX3R5cGVzLmlkbCBiL3Rv b2xzL2xpYnhsL2xpYnhsX3R5cGVzLmlkbAo+PiBpbmRleCBhY2M0YmM5Li4wZTc5NDNlIDEwMDY0 NAo+PiAtLS0gYS90b29scy9saWJ4bC9saWJ4bF90eXBlcy5pZGwKPj4gKysrIGIvdG9vbHMvbGli eGwvbGlieGxfdHlwZXMuaWRsCj4+IEBAIC0zODIsNiArMzgyLDcgQEAgbGlieGxfZGV2aWNlX25p YyA9IFN0cnVjdCgiZGV2aWNlX25pYyIsIFsKPj4gICAgICAoIm5pY3R5cGUiLCBsaWJ4bF9uaWNf dHlwZSksCj4+ICAgICAgKCJyYXRlX2J5dGVzX3Blcl9pbnRlcnZhbCIsIHVpbnQ2NCksCj4+ICAg ICAgKCJyYXRlX2ludGVydmFsX3VzZWNzIiwgdWludDMyKSwKPj4gKyAgICAoIm5ldGRldiIsIHN0 cmluZyksCj4+ICAgICAgXSkKPj4gIAo+PiAgbGlieGxfZGV2aWNlX3BjaSA9IFN0cnVjdCgiZGV2 aWNlX3BjaSIsIFsKPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYyBiL3Rv b2xzL2xpYnhsL3hsX2NtZGltcGwuYwo+PiBpbmRleCBlOTY0YmYxLi45MmE2NGU0IDEwMDY0NAo+ PiAtLS0gYS90b29scy9saWJ4bC94bF9jbWRpbXBsLmMKPj4gKysrIGIvdG9vbHMvbGlieGwveGxf Y21kaW1wbC5jCj4+IEBAIC0xMjA1LDYgKzEyMDUsOSBAQCBzdGF0aWMgdm9pZCBwYXJzZV9jb25m aWdfZGF0YShjb25zdCBjaGFyICpjb25maWdfc291cmNlLAo+PiAgICAgICAgICAgICAgICAgICAg ICBwYXJzZV92aWZfcmF0ZSgmY29uZmlnLCAocDIgKyAxKSwgbmljKTsKPj4gICAgICAgICAgICAg ICAgICB9IGVsc2UgaWYgKCFzdHJjbXAocCwgImFjY2VsIikpIHsKPj4gICAgICAgICAgICAgICAg ICAgICAgZnByaW50ZihzdGRlcnIsICJ0aGUgYWNjZWwgcGFyYW1ldGVyIGZvciB2aWZzIGlzIGN1 cnJlbnRseSBub3Qgc3VwcG9ydGVkXG4iKTsKPj4gKyAgICAgICAgICAgICAgICB9IGVsc2UgaWYg KCFzdHJjbXAocCwgIm5ldGRldiIpKSB7Cj4+ICsgICAgICAgICAgICAgICAgICAgIGZyZWUobmlj LT5uZXRkZXYpOwo+PiArICAgICAgICAgICAgICAgICAgICBuaWMtPm5ldGRldiA9IHN0cmR1cChw MiArIDEpOwo+PiAgICAgICAgICAgICAgICAgIH0KPj4gICAgICAgICAgICAgIH0gd2hpbGUgKChw ID0gc3RydG9rKE5VTEwsICIsIikpICE9IE5VTEwpOwo+PiAgc2tpcF9uaWM6Cj4+IEBAIC01NTEx LDYgKzU1MTQsOCBAQCBpbnQgbWFpbl9uZXR3b3JrYXR0YWNoKGludCBhcmdjLCBjaGFyICoqYXJn dikKPj4gICAgICAgICAgICAgIH0KPj4gICAgICAgICAgfSBlbHNlIGlmIChNQVRDSF9PUFRJT04o ImJyaWRnZSIsICphcmd2LCBvcGFyZykpIHsKPj4gICAgICAgICAgICAgIHJlcGxhY2Vfc3RyaW5n KCZuaWMuYnJpZGdlLCBvcGFyZyk7Cj4+ICsgICAgICAgIH0gZWxzZSBpZiAoTUFUQ0hfT1BUSU9O KCJuZXRkZXYiLCAqYXJndiwgb3BhcmcpKSB7Cj4+ICsgICAgICAgICAgICByZXBsYWNlX3N0cmlu ZygmbmljLm5ldGRldiwgb3BhcmcpOwo+PiAgICAgICAgICB9IGVsc2UgaWYgKE1BVENIX09QVElP TigiaXAiLCAqYXJndiwgb3BhcmcpKSB7Cj4+ICAgICAgICAgICAgICByZXBsYWNlX3N0cmluZygm bmljLmlwLCBvcGFyZyk7Cj4+ICAgICAgICAgIH0gZWxzZSBpZiAoTUFUQ0hfT1BUSU9OKCJzY3Jp cHQiLCAqYXJndiwgb3BhcmcpKSB7Cj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK