xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ulf Kreutzberg <ulf.kreutzberg@hosteurope.de>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 2/4] xl: allow specifying a default gatewaydev in xl.conf
Date: Thu, 14 Feb 2013 16:17:32 +0100	[thread overview]
Message-ID: <511D000C.9030908@citrix.com> (raw)
In-Reply-To: <511CFE2F.2050002@hosteurope.de>

On 14/02/13 16:09, Ulf Kreutzberg wrote:
> Roger,
> 
> 
> after applying patch v2 1/4 and 2/4 (are there missing some?)

Well, you might want to try 3/4 and 4/4 also, but they are not mandatory.

> to git checkout c23ea051ccee613e668b2a87817d49a28215ac8b of
> git://xenbits.xen.org/xen.git xen
> 
> I get the following error(s) during compiling with 'make tools':
> 
> In file included from libxl.h:355,
>                  from xl_cmdtable.c:17:
> _libxl_types.h:437: error: duplicate member ‘gatewaydev’
> make[3]: *** [xl_cmdtable.o] Error 1

Could you take a look at tools/libxl/libxl_types.idl?

You should have something like the following chunk:

libxl_device_nic = Struct("device_nic", [
    ("backend_domid", libxl_domid),
    ("devid", libxl_devid),
    ("mtu", integer),
    ("model", string),
    ("mac", libxl_mac),
    ("ip", string),
    ("bridge", string),
    ("ifname", string),
    ("script", string),
    ("nictype", libxl_nic_type),
    ("rate_bytes_per_interval", uint64),
    ("rate_interval_usecs", uint32),
    ("gatewaydev", string),
    ])

(With only one "gatewaydev").

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-02-14 15:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06 18:04 [PATCH v2 0/4] add vif-route support to libxl/xl Roger Pau Monne
2013-02-06 18:04 ` [PATCH v2 1/4] xl/libxl: add gatewaydev/netdev to vif specification Roger Pau Monne
2013-03-12 16:20   ` Ian Campbell
2013-02-06 18:04 ` [PATCH v2 2/4] xl: allow specifying a default gatewaydev in xl.conf Roger Pau Monne
2013-02-14 15:09   ` Ulf Kreutzberg
2013-02-14 15:17     ` Roger Pau Monné [this message]
2013-02-15 14:06       ` Ulf Kreutzberg
2013-02-18  7:38         ` Roger Pau Monné
2013-02-19 16:04           ` Ulf Kreutzberg
2013-03-04 11:02             ` Roger Pau Monné
2013-03-12 16:39               ` Ulf Kreutzberg
2013-03-12 16:22   ` Ian Campbell
2013-03-12 16:27     ` Ian Campbell
2013-03-13 16:29       ` Roger Pau Monné
2013-02-06 18:04 ` [PATCH v2 3/4] xl: add vif.default.bridge Roger Pau Monne
2013-03-12 16:25   ` Ian Campbell
2013-03-13 16:40     ` Roger Pau Monné
2013-02-06 18:04 ` [PATCH v2 4/4] xl: add vif.default.script Roger Pau Monne
2013-02-07 11:31   ` George Dunlap
2013-03-12 16:25   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511D000C.9030908@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=ulf.kreutzberg@hosteurope.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).