From: George Dunlap <george.dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
WeiLiu <wei.liu2@citrix.com>,
"George Dunlap" <George.Dunlap@eu.citrix.com>,
"Tim Deegan" <tim@xen.org>,
IanJackson <ian.jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH] build: Rename as-insn-check to as-insn-add
Date: Thu, 22 Feb 2018 12:39:15 +0000 [thread overview]
Message-ID: <511bbc13-b5c5-73a1-9f8c-47df50705d69@citrix.com> (raw)
In-Reply-To: <5A8EC40A02000078001AA5CD@prv-mh.provo.novell.com>
On 02/22/2018 12:22 PM, Jan Beulich wrote:
>>>> On 22.02.18 at 12:41, <andrew.cooper3@citrix.com> wrote:
>> On 22/02/18 11:33, Jan Beulich wrote:
>>>>>> On 22.02.18 at 11:51, <andrew.cooper3@citrix.com> wrote:
>>>> as-insn-check mutates the passed-in flags. Rename it to as-insn-add, in line
>>>> with cc-option-add. Update all callers.
>>> I'm not convinced - cc-option-add makes relatively clear that
>>> something is being added to the options passed to CC. If I
>>> take as-insn-add this way, the macro would need to add an
>>> insn to the AS invocation. While I agree as-insn-check doesn't
>>> make clear that it adds any options, I still find this less
>>> misleading than the suggested new name. Let's see what
>>> others think.
>>
>> I'm open to better name suggestions.
>
> The best I can come up with is, well, as-insn-check, as that
> reasonably describes at least part of what the construct does.
> as-insn-check-and-add-option, besides being too long, isn't
> meaningfully better.
We're definitely getting into bikeshed territory here. I agree with
Andy that 'check' doesn't really convey that something changed. Is the
check-and-add "add it if it doesn't exist already"? Or add it if some
other check passes / fails?
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-22 12:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 10:51 [PATCH] build: Rename as-insn-check to as-insn-add Andrew Cooper
2018-02-22 11:33 ` Jan Beulich
2018-02-22 11:41 ` Andrew Cooper
2018-02-22 12:22 ` Jan Beulich
2018-02-22 12:39 ` George Dunlap [this message]
2018-02-22 13:39 ` Jan Beulich
2018-02-23 11:40 ` Andrew Cooper
2018-02-23 11:46 ` Roger Pau Monné
2018-02-23 11:47 ` Ian Jackson
2018-02-23 11:58 ` Jan Beulich
2018-02-23 12:37 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511bbc13-b5c5-73a1-9f8c-47df50705d69@citrix.com \
--to=george.dunlap@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).