From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Malcolm Crossley <malcolm.crossley@citrix.com>,
"Tim (Xen.org)" <tim@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH V3] vmx/nmi: Do not use self_nmi() in VMEXIT handler
Date: Thu, 28 Feb 2013 12:32:28 +0000 [thread overview]
Message-ID: <512F4E5C.8090308@citrix.com> (raw)
In-Reply-To: <512F384602000078000C1D5B@nat28.tlf.novell.com>
On 28/02/13 09:58, Jan Beulich wrote:
>>>> On 22.11.12 at 17:12, Jan Beulich wrote:
>>>>> On 22.11.12 at 17:05, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>>> On 22/11/12 15:55, Jan Beulich wrote:
>>>>>>> On 22.11.12 at 16:37, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>>>>> A quick solution would be to execute a noop function with
>>>>> run_in_exception_handler(). Alternatively, I can code enable_nmi() or
>>>>> so which does an inline iret to itself. Which of these would you prefer?
>>>> I would actually consider avoiding to run softirqs altogether in that
>>>> case, just like native Linux doesn't do any event or scheduler
>>>> processing in that case.
>>> That would probably be the easiest solution.
>>>
>>> I was already going to do the same for the rentrant NMI and MCE handling
>>> case (and also the process pending upcalls checking), due to the
>>> complexities of fixing the race condition at the end of the handler.
>>>
>>> Unfortunately, I don't think I have time to look at this issue
>>> immediately, but if it is ok to wait till the beginning of next week, I
>> That's fine of course.
> So that was 3 months ago, and we're likely going to need to do
> further unfixed releases if this won't move forward. Can you
> estimate whether you'll be able to get back to this?
>
> Jan
>
With the new enable_nmi() function, I can spin a workaround patch quite
quickly, and will try to get that done this week. The remainder of the
reentrant tangle is still happening very slowly.
~Andrew
next prev parent reply other threads:[~2013-02-28 12:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 15:00 [PATCH V3] vmx/nmi: Do not use self_nmi() in VMEXIT handler Andrew Cooper
2012-11-22 15:15 ` Jan Beulich
2012-11-22 15:16 ` Andrew Cooper
2012-11-22 15:21 ` Jan Beulich
2012-11-22 15:37 ` Andrew Cooper
2012-11-22 15:55 ` Jan Beulich
2012-11-22 16:05 ` Andrew Cooper
2012-11-22 16:12 ` Jan Beulich
2012-11-22 16:31 ` Andrew Cooper
2013-02-28 9:58 ` Jan Beulich
2013-02-28 12:32 ` Andrew Cooper [this message]
2013-02-28 13:00 ` Tim Deegan
2013-02-28 13:12 ` Andrew Cooper
2013-02-28 13:39 ` Jan Beulich
2013-02-28 14:25 ` Tim Deegan
2013-02-28 14:42 ` Jan Beulich
2013-02-28 14:45 ` Andrew Cooper
2013-02-28 14:49 ` Tim Deegan
2013-02-28 15:01 ` Jan Beulich
2013-02-28 15:41 ` Jan Beulich
2013-02-28 15:52 ` Andrew Cooper
2013-02-28 15:55 ` Tim Deegan
2013-02-28 16:12 ` Jan Beulich
2013-02-28 16:01 ` Keir Fraser
2013-02-28 16:17 ` Jan Beulich
2013-02-28 19:02 ` Keir Fraser
2013-03-01 10:49 ` [PATCH v2 0/2] x86: defer processing events on the NMI exit path Jan Beulich
2013-03-01 10:56 ` [PATCH v2 1/2] " Jan Beulich
2013-03-01 11:37 ` Andrew Cooper
2013-03-01 11:53 ` Jan Beulich
2013-03-01 15:56 ` Keir Fraser
2013-03-01 16:01 ` Andrew Cooper
2013-03-01 16:08 ` Jan Beulich
2013-03-01 10:57 ` [PATCH v2 2/2] x86: don't rely on __softirq_pending to be the first field in irq_cpustat_t Jan Beulich
2013-03-01 15:55 ` [PATCH v2 0/2] x86: defer processing events on the NMI exit path Keir Fraser
2013-02-28 13:42 ` [PATCH V3] vmx/nmi: Do not use self_nmi() in VMEXIT handler Jan Beulich
2013-02-28 14:04 ` Tim Deegan
2013-02-28 14:51 ` Konrad Rzeszutek Wilk
2012-11-22 15:22 ` Mats Petersson
2012-11-22 16:00 ` Jan Beulich
2012-11-22 17:34 ` Tim Deegan
2012-11-26 11:50 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F4E5C.8090308@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=malcolm.crossley@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).