From: George Dunlap <george.dunlap@eu.citrix.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel <xen-devel@lists.xen.org>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.
Date: Fri, 8 Mar 2013 11:18:45 +0000 [thread overview]
Message-ID: <5139C915.5080309@eu.citrix.com> (raw)
In-Reply-To: <28ABF94D2CD0737DF699D761@nimrod.local>
On 08/03/13 10:50, Alex Bligh wrote:
>
> --On 8 March 2013 10:35:43 +0000 George Dunlap <George.Dunlap@eu.citrix.com> wrote:
>
>> If you can verify that it's always safe to use qemu without O_DIRECT
>> (or that it's not any safer to use it), then you should just remove
>> it; no point in having options which have no practical effect. But in
>> that case you should make sure to mention in the commit message why
>> O_DIRECT isn't actually needed.
> How about me adding the following:
>
> This brings PV devices in line with emulated devices. Removing O_DIRECT
> is safe as barrier operations are now correctly passed through.
That sounds good to me -- thanks, Alex.
-George
next prev parent reply other threads:[~2013-03-08 11:18 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 14:54 Fatal crash on xen4.2 HVM + qemu-xen dm + NFS Alex Bligh
2012-12-17 10:10 ` Jan Beulich
2012-12-17 17:09 ` Alex Bligh
2013-01-16 10:56 ` Alex Bligh
2013-01-16 14:34 ` Stefano Stabellini
2013-01-16 15:06 ` Alex Bligh
2013-01-16 16:00 ` Alex Bligh
2013-01-16 16:27 ` Stefano Stabellini
2013-01-16 17:13 ` Alex Bligh
2013-01-16 17:33 ` Stefano Stabellini
2013-01-16 17:39 ` Stefano Stabellini
2013-01-16 18:14 ` Alex Bligh
2013-01-16 18:49 ` Stefano Stabellini
2013-01-16 19:00 ` Stefano Stabellini
2013-01-17 7:58 ` Alex Bligh
2013-01-16 18:12 ` Alex Bligh
2013-01-21 15:15 ` Alex Bligh
2013-01-21 15:23 ` Ian Campbell
2013-01-21 15:35 ` Alex Bligh
2013-01-21 15:50 ` Ian Campbell
2013-01-21 16:33 ` Alex Bligh
2013-01-21 16:51 ` Ian Campbell
2013-01-21 17:06 ` Alex Bligh
2013-01-21 17:29 ` Ian Campbell
2013-01-21 17:31 ` Alex Bligh
2013-01-21 17:32 ` Ian Campbell
2013-01-21 18:14 ` Alex Bligh
2013-01-22 10:05 ` Ian Campbell
2013-01-22 13:02 ` Alex Bligh
2013-01-22 13:13 ` Ian Campbell
2013-01-21 20:37 ` Alex Bligh
2013-01-22 10:07 ` Ian Campbell
2013-01-22 13:01 ` Alex Bligh
2013-01-22 13:14 ` Ian Campbell
2013-01-22 13:18 ` Alex Bligh
2013-01-22 10:13 ` Ian Campbell
2013-01-22 12:59 ` Alex Bligh
2013-01-22 15:46 ` Stefano Stabellini
2013-01-22 15:42 ` Stefano Stabellini
2013-01-22 16:09 ` Stefano Stabellini
2013-01-22 20:31 ` Alex Bligh
2013-01-23 11:52 ` Stefano Stabellini
2013-01-23 15:19 ` Alex Bligh
2013-01-23 16:29 ` Stefano Stabellini
2013-01-25 11:28 ` Alex Bligh
2013-02-05 15:40 ` Alex Bligh
2013-02-22 17:28 ` Alex Bligh
2013-02-22 17:41 ` Konrad Rzeszutek Wilk
2013-02-22 18:00 ` Stefano Stabellini
2013-02-22 19:53 ` Alex Bligh
2013-03-06 11:50 ` Alex Bligh
2013-03-07 1:01 ` Konrad Rzeszutek Wilk
2013-03-07 4:15 ` Stefano Stabellini
2013-03-07 10:47 ` [PATCH] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes Alex Bligh
2013-03-08 3:18 ` Stefano Stabellini
2013-03-08 9:25 ` [PATCHv2] " Alex Bligh
2013-03-08 9:26 ` [PATCH] " Alex Bligh
2013-03-08 10:17 ` George Dunlap
2013-03-08 10:27 ` Alex Bligh
2013-03-08 10:35 ` George Dunlap
2013-03-08 10:50 ` Alex Bligh
2013-03-08 11:18 ` George Dunlap [this message]
2013-03-08 11:40 ` [PATCHv3] " Alex Bligh
2013-03-08 12:54 ` George Dunlap
2013-03-11 14:02 ` Alex Bligh
2013-03-11 14:42 ` George Dunlap
2013-03-11 17:48 ` Konrad Rzeszutek Wilk
2013-03-11 17:55 ` Ian Jackson
2013-03-14 17:06 ` Alex Bligh
2013-03-14 18:26 ` Ian Jackson
2013-03-12 12:08 ` Ian Campbell
2013-03-14 18:37 ` Stefano Stabellini
2013-03-14 19:30 ` Ian Jackson
2013-03-14 19:56 ` Alex Bligh
2013-03-15 9:28 ` Ian Campbell
2013-03-15 10:43 ` Stefano Stabellini
2013-03-15 11:21 ` Ian Jackson
2013-03-15 11:28 ` Stefano Stabellini
2013-03-15 11:37 ` Ian Jackson
2013-03-15 11:43 ` Stefano Stabellini
2013-03-15 12:43 ` Alex Bligh
2013-03-15 12:50 ` Ian Campbell
2013-03-15 18:31 ` Ian Jackson
2013-03-18 10:29 ` Alex Bligh
2013-03-18 11:47 ` Stefano Stabellini
2013-03-18 12:21 ` Alex Bligh
2013-03-08 11:41 ` [PATCH] " Alex Bligh
2013-03-08 10:28 ` George Dunlap
2013-03-08 10:45 ` Alex Bligh
2013-03-07 10:51 ` Fatal crash on xen4.2 HVM + qemu-xen dm + NFS Alex Bligh
2013-03-07 8:16 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5139C915.5080309@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=alex@alex.org.uk \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).