From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George.Dunlap@eu.citrix.com,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Time Skewing on Windows XP
Date: Thu, 14 Mar 2013 11:21:35 -0500 [thread overview]
Message-ID: <5141F90F.6060408@amd.com> (raw)
In-Reply-To: <514203A502000078000C59E2@nat28.tlf.novell.com>
On 3/14/2013 11:06 AM, Jan Beulich wrote:
>>>> On 14.03.13 at 16:16, Suravee Suthikulanit<suravee.suthikulpanit@amd.com> wrote:
>> I finally traced the issue back to the patch that this first happened. This
>> bug started in the patch :
>>
>> H86/HVM: assorted RTC emulation adjustment (w/ git commit id
>> 620d5dad54008e40798c4a0c4322aef274c36fa3)
>>
>> I believe there are some issues with the changes in rtc_ioport_read in the
>> arch/x86/hvm/rtc.c and in the pt_update_irq().
> One thing you may want to try is remove the call from REG_C
> read to rtc_timer_update() again - on a second thought it may
> be wrong to do it here, as (other than check_update_timer()
> and alarm_timer_update()) the function doesn't change with
> RTC_PF getting cleared (i.e. I may have wrongly added the call
> in analogy to the other two).
If I do the followings, things start working again:
1. remove the rtc_timer_update() in the rtc_ioport_read()
2. Revert back the "rtc_periodic_cb()" and remove the
"rtc_periodic_interrupt()"
What was the purpose of changing the "rtc_periodic_cb()" to
"rtc_periodic_interrupt()" ?
Suravee
> I would expect the issue to be that create_periodic_time()
> pointlessly destroys and then recreates an identical rate timer.
>
> I'm puzzled though that some Windows versions depend on
> the RTC to maintain their wall clock time...
>
> Jan
>
>
next prev parent reply other threads:[~2013-03-14 16:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 4:40 Time Skewing on Windows XP Suravee Suthikulpanit
2013-03-12 5:00 ` Steven Haigh
2013-03-12 8:03 ` Jan Beulich
2013-03-14 15:16 ` Suravee Suthikulanit
2013-03-14 16:06 ` Jan Beulich
2013-03-14 16:21 ` Suravee Suthikulanit [this message]
2013-03-14 16:34 ` Jan Beulich
2013-03-14 16:38 ` Suravee Suthikulanit
2013-03-14 17:03 ` Jan Beulich
2013-03-14 16:30 ` Tim Deegan
2013-03-14 16:43 ` Jan Beulich
2013-03-14 17:08 ` Tim Deegan
2013-03-14 20:23 ` Suravee Suthikulanit
2013-03-15 8:23 ` Jan Beulich
2013-03-21 12:33 ` Tim Deegan
2013-03-21 17:05 ` Jan Beulich
2013-03-14 16:24 ` Tim Deegan
2013-03-14 16:28 ` Jan Beulich
2013-03-12 9:13 ` Paul Durrant
2013-03-12 15:55 ` Suravee Suthikulanit
2013-03-12 16:13 ` Boris Ostrovsky
2013-03-12 18:25 ` Suravee Suthikulanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5141F90F.6060408@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).