From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH v1 04/12] libxl: pack hotplug related variables Date: Thu, 14 Mar 2013 17:44:07 +0100 Message-ID: <5141FE57.7010706@citrix.com> References: <1358963317-10221-1-git-send-email-roger.pau@citrix.com> <1358963317-10221-5-git-send-email-roger.pau@citrix.com> <20800.37393.525552.351144@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20800.37393.525552.351144@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 13/03/13 15:49, Ian Jackson wrote: > Roger Pau Monne writes ("[Xen-devel] [PATCH v1 04/12] libxl: pack hotplug= related variables"): >> Create a new struct to hold hotplug related variables that are >> scattered in libxl__ao_device. We will later expand the number of >> hotplug related variables, so it's best to have them packed >> >> Signed-off-by: Roger Pau Monn=E9 >> Cc: Ian Campbell > = > I think you should avoid the word "packed" which normally makes people > think of removing structure memory layout padding. "grouped" > perhaps ? > = > Apart from that, which I think is just a comment about the commit > message: > = > Acked-by: Ian Jackson Thanks, I've fixed the commit message and added your Ack.