From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH v1 10/12] libxl: add local attach support for new hotplug scripts Date: Fri, 15 Mar 2013 12:59:03 +0100 Message-ID: <51430D07.8010902@citrix.com> References: <1358963317-10221-1-git-send-email-roger.pau@citrix.com> <1358963317-10221-11-git-send-email-roger.pau@citrix.com> <20800.43103.673387.713988@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20800.43103.673387.713988@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 13/03/13 17:25, Ian Jackson wrote: > Roger Pau Monne writes ("[Xen-devel] [PATCH v1 10/12] libxl: add local attach support for new hotplug scripts"): >> Adds support for locally attaching disks that use the new hotplug >> script interface, by calling the localattach/localdetach operations >> and returning a block device that can be used to execute pygrub. > > This is an optimisation, isn't it ? In the sense that nothing should > go wrong if we don't have this code ? The status-quo right now is that custom hotplug scripts cannot be used in conjunction with pygrub, because we need to pass pygrub either a block device or a raw file. This patch adds the necessary functionality in order to attach the block device before executing pygrub, so we can use this new hotplug scripts with pygrub, providing extra functionality.