* [PATCH v2] Add and fix missing format entries for xentrace_format tool.
@ 2013-03-15 19:48 Konrad Rzeszutek Wilk
2013-03-15 19:48 ` [PATCH 1/4] trace: Use correct trace class for power management changes Konrad Rzeszutek Wilk
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-03-15 19:48 UTC (permalink / raw)
To: xen-devel, george.dunlap
Hey George,
Two of these you graciously Ack-ed. There are two more new ones that I added
as I was looking over a trace contents created by xentrace_format.
Please take a look at your leisure. Thank you!
tools/xentrace/formats | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
Konrad Rzeszutek Wilk (4):
trace: Use correct trace class for power management changes.
trace: Add trace events for IRQ activities.
trace: Add the other variant of do_block.
trace: Add reason for NMI exit TRAP
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/4] trace: Use correct trace class for power management changes.
2013-03-15 19:48 [PATCH v2] Add and fix missing format entries for xentrace_format tool Konrad Rzeszutek Wilk
@ 2013-03-15 19:48 ` Konrad Rzeszutek Wilk
2013-03-15 19:48 ` [PATCH 2/4] trace: Add trace events for IRQ activities Konrad Rzeszutek Wilk
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-03-15 19:48 UTC (permalink / raw)
To: xen-devel, george.dunlap; +Cc: Konrad Rzeszutek Wilk
Previous to this patch we would see in the trace file:
CPU28 1753503175371 (+ 8496) unknown (0x0000000000801002) [ 0x00000004 0x4158a498 0x000003a1 0x000027e6 0x00000000 0x00000000 0x00000000 ]
CPU28 1753505321239 (+ 2145868) unknown (0x0000000000801003) [ 0x00000004 0x4166dca7 0x000000fa 0x00000000 0x00000000 0x00000000 0x00000000 ]
CPU28 1753505343756 (+ 22517) unknown (0x0000000000801002) [ 0x00000004 0x41670fe5 0x00001284 0x00003766 0x00000000 0x00000000 0x00000000 ]
CPU28 1753521413711 (+16069955) unknown (0x0000000000801003) [ 0x00000004 0x41d1e02c 0x000000ab 0x00000000 0x00000000 0x00000000 0x00000000 ]
instead of:
CPU28 1753503175371 (+ 8496) cpu_idle_entry [ C0 -> C4, acpi_pm_tick = 1096328344, expected = 929us, predicted = 10214us ]
CPU28 1753505321239 (+ 2145868) cpu_idle_exit [ C4 -> C0, acpi_pm_tick = 1097260199, irq = 250 0 0 0 ]
CPU28 1753505343756 (+ 22517) cpu_idle_entry [ C0 -> C4, acpi_pm_tick = 1097273317, expected = 4740us, predicted = 14182us ]
CPU28 1753521413711 (+16069955) cpu_idle_exit [ C4 -> C0, acpi_pm_tick = 1104273452, irq = 171 0 0 0 ]
The patch that added the cpu_idle_[entry|exit] was using the
TRC_HW_IRQ class (0x00802000) instead of TRC_HW_PM (0x00801000)
as a base.
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
tools/xentrace/formats | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/xentrace/formats b/tools/xentrace/formats
index 928e1d7..b4e3d05 100644
--- a/tools/xentrace/formats
+++ b/tools/xentrace/formats
@@ -139,5 +139,5 @@
0x0040f10f CPU%(cpu)d %(tsc)d (+%(reltsc)8d) shadow_emulate_resync_only [ gfn = 0x%(2)08x%(1)08x ]
0x00801001 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) cpu_freq_change [ %(1)dMHz -> %(2)dMHz ]
-0x00802001 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) cpu_idle_entry [ C0 -> C%(1)d, acpi_pm_tick = %(2)d, expected = %(3)dus, predicted = %(4)dus ]
-0x00802002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) cpu_idle_exit [ C%(1)d -> C0, acpi_pm_tick = %(2)d, irq = %(3)d %(4)d %(5)d %(6)d ]
+0x00801002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) cpu_idle_entry [ C0 -> C%(1)d, acpi_pm_tick = %(2)d, expected = %(3)dus, predicted = %(4)dus ]
+0x00801003 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) cpu_idle_exit [ C%(1)d -> C0, acpi_pm_tick = %(2)d, irq = %(3)d %(4)d %(5)d %(6)d ]
--
1.8.0.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/4] trace: Add trace events for IRQ activities.
2013-03-15 19:48 [PATCH v2] Add and fix missing format entries for xentrace_format tool Konrad Rzeszutek Wilk
2013-03-15 19:48 ` [PATCH 1/4] trace: Use correct trace class for power management changes Konrad Rzeszutek Wilk
@ 2013-03-15 19:48 ` Konrad Rzeszutek Wilk
2013-03-15 19:48 ` [PATCH 3/4] trace: Add the other variant of do_block Konrad Rzeszutek Wilk
2013-03-15 19:48 ` [PATCH 4/4] trace: Add reason for NMI exit TRAP Konrad Rzeszutek Wilk
3 siblings, 0 replies; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-03-15 19:48 UTC (permalink / raw)
To: xen-devel, george.dunlap; +Cc: Konrad Rzeszutek Wilk
This expands the format to include the class of TRC_HW_IRQ.
This means that instead of:
CPU28 1753521436727 (+ 3252) unknown (0x0000000000802008) [ 0x0000006c 0x4605709c 0x4605b682 0x00000000 0x00000000 0x00000000 0x00000000 ]
we now see:
CPU28 1753521436727 (+ 3252) do_irq [ irq = 108, began = 1174761628us, ended = 1174779522us ]
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
tools/xentrace/formats | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tools/xentrace/formats b/tools/xentrace/formats
index b4e3d05..00f0263 100644
--- a/tools/xentrace/formats
+++ b/tools/xentrace/formats
@@ -141,3 +141,12 @@
0x00801001 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) cpu_freq_change [ %(1)dMHz -> %(2)dMHz ]
0x00801002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) cpu_idle_entry [ C0 -> C%(1)d, acpi_pm_tick = %(2)d, expected = %(3)dus, predicted = %(4)dus ]
0x00801003 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) cpu_idle_exit [ C%(1)d -> C0, acpi_pm_tick = %(2)d, irq = %(3)d %(4)d %(5)d %(6)d ]
+
+0x00802001 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) cleanup_move_delayed [ irq = %(1)d, vector 0x%(2)x on CPU%(3)d ]
+0x00802002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) cleanup_move [ irq = %(1)d, vector 0x%(2)x on CPU%(3)d ]
+0x00802003 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) bind_vector [ irq = %(1)d = vector 0x%(2)x, CPU mask: 0x%(3)08x ]
+0x00802004 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) clear_vector [ irq = %(1)d = vector 0x%(2)x, CPU mask: 0x%(3)08x ]
+0x00802005 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) move_vector [ irq = %(1)d had vector 0x%(2)x on CPU%(3)d ]
+0x00802006 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) assign_vector [ irq = %(1)d = vector 0x%(2)x, CPU mask: 0x%(3)08x ]
+0x00802007 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) bogus_vector [ 0x%(1)x ]
+0x00802008 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) do_irq [ irq = %(1)d, began = %(2)dus, ended = %(3)dus ]
--
1.8.0.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/4] trace: Add the other variant of do_block.
2013-03-15 19:48 [PATCH v2] Add and fix missing format entries for xentrace_format tool Konrad Rzeszutek Wilk
2013-03-15 19:48 ` [PATCH 1/4] trace: Use correct trace class for power management changes Konrad Rzeszutek Wilk
2013-03-15 19:48 ` [PATCH 2/4] trace: Add trace events for IRQ activities Konrad Rzeszutek Wilk
@ 2013-03-15 19:48 ` Konrad Rzeszutek Wilk
2013-03-18 11:43 ` George Dunlap
2013-03-15 19:48 ` [PATCH 4/4] trace: Add reason for NMI exit TRAP Konrad Rzeszutek Wilk
3 siblings, 1 reply; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-03-15 19:48 UTC (permalink / raw)
To: xen-devel, george.dunlap; +Cc: Konrad Rzeszutek Wilk
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
tools/xentrace/formats | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/xentrace/formats b/tools/xentrace/formats
index 00f0263..5c26e21 100644
--- a/tools/xentrace/formats
+++ b/tools/xentrace/formats
@@ -25,6 +25,7 @@
0x00028004 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) domain_wake [ domid = 0x%(1)08x, edomid = 0x%(2)08x ]
0x00028005 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) do_yield [ domid = 0x%(1)08x, edomid = 0x%(2)08x ]
0x00028006 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) do_block [ domid = 0x%(1)08x, edomid = 0x%(2)08x ]
+0x00022006 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) do_block [ dom:vcpu = 0x%(1)08x, domid = 0x%(2)08x ]
0x00028007 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) domain_shutdown [ domid = 0x%(1)08x, edomid = 0x%(2)08x, reason = 0x%(3)08x ]
0x00028008 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) sched_ctl
0x00028009 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) sched_adjdom [ domid = 0x%(1)08x ]
--
1.8.0.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/4] trace: Add reason for NMI exit TRAP
2013-03-15 19:48 [PATCH v2] Add and fix missing format entries for xentrace_format tool Konrad Rzeszutek Wilk
` (2 preceding siblings ...)
2013-03-15 19:48 ` [PATCH 3/4] trace: Add the other variant of do_block Konrad Rzeszutek Wilk
@ 2013-03-15 19:48 ` Konrad Rzeszutek Wilk
2013-03-18 11:44 ` George Dunlap
3 siblings, 1 reply; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-03-15 19:48 UTC (permalink / raw)
To: xen-devel, george.dunlap; +Cc: Konrad Rzeszutek Wilk
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
tools/xentrace/formats | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/xentrace/formats b/tools/xentrace/formats
index 5c26e21..67fd42d 100644
--- a/tools/xentrace/formats
+++ b/tools/xentrace/formats
@@ -78,6 +78,7 @@
0x0008201a CPU%(cpu)d %(tsc)d (+%(reltsc)8d) RDTSC [ value = 0x%(2)08x%(1)08x ]
0x00082020 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) INTR_WINDOW [ value = 0x%(1)08x ]
0x00082021 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) NPF [ gpa = 0x%(2)08x%(1)08x mfn = 0x%(4)08x%(3)08x qual = 0x%(5)04x p2mt = 0x%(6)04x ]
+0x00082023 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) TRAP [ vector = 0x%(1)02x ]
0x0010f001 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) page_grant_map [ domid = %(1)d ]
0x0010f002 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) page_grant_unmap [ domid = %(1)d ]
--
1.8.0.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 3/4] trace: Add the other variant of do_block.
2013-03-15 19:48 ` [PATCH 3/4] trace: Add the other variant of do_block Konrad Rzeszutek Wilk
@ 2013-03-18 11:43 ` George Dunlap
0 siblings, 0 replies; 7+ messages in thread
From: George Dunlap @ 2013-03-18 11:43 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: xen-devel@lists.xensource.com
On 15/03/13 19:48, Konrad Rzeszutek Wilk wrote:
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
> ---
> tools/xentrace/formats | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/xentrace/formats b/tools/xentrace/formats
> index 00f0263..5c26e21 100644
> --- a/tools/xentrace/formats
> +++ b/tools/xentrace/formats
> @@ -25,6 +25,7 @@
> 0x00028004 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) domain_wake [ domid = 0x%(1)08x, edomid = 0x%(2)08x ]
> 0x00028005 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) do_yield [ domid = 0x%(1)08x, edomid = 0x%(2)08x ]
> 0x00028006 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) do_block [ domid = 0x%(1)08x, edomid = 0x%(2)08x ]
> +0x00022006 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) do_block [ dom:vcpu = 0x%(1)08x, domid = 0x%(2)08x ]
> 0x00028007 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) domain_shutdown [ domid = 0x%(1)08x, edomid = 0x%(2)08x, reason = 0x%(3)08x ]
> 0x00028008 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) sched_ctl
> 0x00028009 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) sched_adjdom [ domid = 0x%(1)08x ]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4/4] trace: Add reason for NMI exit TRAP
2013-03-15 19:48 ` [PATCH 4/4] trace: Add reason for NMI exit TRAP Konrad Rzeszutek Wilk
@ 2013-03-18 11:44 ` George Dunlap
0 siblings, 0 replies; 7+ messages in thread
From: George Dunlap @ 2013-03-18 11:44 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: xen-devel@lists.xensource.com
On 15/03/13 19:48, Konrad Rzeszutek Wilk wrote:
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-03-18 11:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-15 19:48 [PATCH v2] Add and fix missing format entries for xentrace_format tool Konrad Rzeszutek Wilk
2013-03-15 19:48 ` [PATCH 1/4] trace: Use correct trace class for power management changes Konrad Rzeszutek Wilk
2013-03-15 19:48 ` [PATCH 2/4] trace: Add trace events for IRQ activities Konrad Rzeszutek Wilk
2013-03-15 19:48 ` [PATCH 3/4] trace: Add the other variant of do_block Konrad Rzeszutek Wilk
2013-03-18 11:43 ` George Dunlap
2013-03-15 19:48 ` [PATCH 4/4] trace: Add reason for NMI exit TRAP Konrad Rzeszutek Wilk
2013-03-18 11:44 ` George Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).