* [PATCH] ACPI/ERST: Name ERST table in otherwise opaque error messages
@ 2013-03-19 22:55 Andrew Cooper
2013-03-20 8:35 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2013-03-19 22:55 UTC (permalink / raw)
To: xen-devel; +Cc: -n, Keir Fraser, Jan Beulich
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff -r a6b81234b189 -r 7fdef201c0b4 xen/drivers/acpi/apei/erst.c
--- a/xen/drivers/acpi/apei/erst.c
+++ b/xen/drivers/acpi/apei/erst.c
@@ -781,11 +781,11 @@ int __init erst_init(void)
status = acpi_get_table(ACPI_SIG_ERST, 0,
(struct acpi_table_header **)&erst_tab);
if (status == AE_NOT_FOUND) {
- printk(KERN_ERR "Table is not found!\n");
+ printk(KERN_ERR "ERST table is not found!\n");
return -ENODEV;
} else if (ACPI_FAILURE(status)) {
const char *msg = acpi_format_exception(status);
- printk(KERN_ERR "Failed to get table, %s\n", msg);
+ printk(KERN_ERR "Failed to get ESRT table, %s\n", msg);
return -EINVAL;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI/ERST: Name ERST table in otherwise opaque error messages
2013-03-19 22:55 [PATCH] ACPI/ERST: Name ERST table in otherwise opaque error messages Andrew Cooper
@ 2013-03-20 8:35 ` Jan Beulich
2013-03-20 11:29 ` Andrew Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2013-03-20 8:35 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Keir Fraser, -n, xen-devel
>>> On 19.03.13 at 23:55, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> diff -r a6b81234b189 -r 7fdef201c0b4 xen/drivers/acpi/apei/erst.c
> --- a/xen/drivers/acpi/apei/erst.c
> +++ b/xen/drivers/acpi/apei/erst.c
> @@ -781,11 +781,11 @@ int __init erst_init(void)
> status = acpi_get_table(ACPI_SIG_ERST, 0,
> (struct acpi_table_header **)&erst_tab);
> if (status == AE_NOT_FOUND) {
> - printk(KERN_ERR "Table is not found!\n");
> + printk(KERN_ERR "ERST table is not found!\n");
> return -ENODEV;
> } else if (ACPI_FAILURE(status)) {
> const char *msg = acpi_format_exception(status);
> - printk(KERN_ERR "Failed to get table, %s\n", msg);
> + printk(KERN_ERR "Failed to get ESRT table, %s\n", msg);
I'll fix the spelling, and once at it also lower the severities (these
really aren't errors - the former is informational, while the latter
is no more than a warning imo).
Jan
> return -EINVAL;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI/ERST: Name ERST table in otherwise opaque error messages
2013-03-20 8:35 ` Jan Beulich
@ 2013-03-20 11:29 ` Andrew Cooper
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2013-03-20 11:29 UTC (permalink / raw)
To: Jan Beulich; +Cc: Keir (Xen.org), xen-devel@lists.xen.org
On 20/03/13 08:35, Jan Beulich wrote:
>>>> On 19.03.13 at 23:55, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>
>> diff -r a6b81234b189 -r 7fdef201c0b4 xen/drivers/acpi/apei/erst.c
>> --- a/xen/drivers/acpi/apei/erst.c
>> +++ b/xen/drivers/acpi/apei/erst.c
>> @@ -781,11 +781,11 @@ int __init erst_init(void)
>> status = acpi_get_table(ACPI_SIG_ERST, 0,
>> (struct acpi_table_header **)&erst_tab);
>> if (status == AE_NOT_FOUND) {
>> - printk(KERN_ERR "Table is not found!\n");
>> + printk(KERN_ERR "ERST table is not found!\n");
>> return -ENODEV;
>> } else if (ACPI_FAILURE(status)) {
>> const char *msg = acpi_format_exception(status);
>> - printk(KERN_ERR "Failed to get table, %s\n", msg);
>> + printk(KERN_ERR "Failed to get ESRT table, %s\n", msg);
> I'll fix the spelling, and once at it also lower the severities (these
> really aren't errors - the former is informational, while the latter
> is no more than a warning imo).
>
> Jan
Thanks - I realised the spelling error after I left last night and was
going to submit a correction if you hadn't beaten me to it.
~Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-20 11:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-19 22:55 [PATCH] ACPI/ERST: Name ERST table in otherwise opaque error messages Andrew Cooper
2013-03-20 8:35 ` Jan Beulich
2013-03-20 11:29 ` Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).