From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 1/2] libxl: Introduce functions to add and remove host USB devices to an HVM guest
Date: Wed, 20 Mar 2013 17:04:41 +0000 [thread overview]
Message-ID: <5149EC29.6070401@eu.citrix.com> (raw)
In-Reply-To: <20809.59721.561353.891856@mariner.uk.xensource.com>
On 20/03/13 16:52, Ian Jackson wrote:
> George Dunlap writes ("[PATCH v2 1/2] libxl: Introduce functions to add and remove host USB devices to an HVM guest"):
>> Devices must be removed by "id", an identifying string, which must be
>> specified when the device is created. The caller can either pass one
>> in to request; if none is passed in, then libxl will choose one and
>> pass it back to the caller. In the second case, it will return a
>> string containing the id used in the "id" field of the device struct.
> IMO we shouldn't expose these ids like this. Rather, we should do
> what we do with block, network, etc. and have functions for listing
> and removing devices by their virtual names ("device tree path" or
> whatever as the guest sees it).
>
> If QMP is deficient then this may mean keeping a separate list
> somewhere.
Right -- I was hoping to have such an implementation as a
"nice-to-have", which I would try to get in as a best-effort, rather
than a requirement.
-George
next prev parent reply other threads:[~2013-03-20 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 16:41 [PATCH v2 1/2] libxl: Introduce functions to add and remove host USB devices to an HVM guest George Dunlap
2013-03-20 16:41 ` [PATCH v2 2/2] xl: Add hvm-host-usb-add and hvm-host-usb-del commands George Dunlap
2013-03-20 16:52 ` [PATCH v2 1/2] libxl: Introduce functions to add and remove host USB devices to an HVM guest Ian Jackson
2013-03-20 17:04 ` George Dunlap [this message]
2013-03-20 17:48 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5149EC29.6070401@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).