From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel De Graaf Subject: Re: [PATCH] drivers/tpm-xen: Change vTPM shared page ABI Date: Fri, 22 Mar 2013 10:37:41 -0400 Message-ID: <514C6CB5.70805@tycho.nsa.gov> References: <1363896689-11086-1-git-send-email-dgdegra@tycho.nsa.gov> <1363896747-11187-1-git-send-email-dgdegra@tycho.nsa.gov> <20130322124108.GA3199@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130322124108.GA3199@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Matthew.Fioravante@jhuapl.edu, Ian.Campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 03/22/2013 08:41 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 21, 2013 at 04:12:27PM -0400, Daniel De Graaf wrote: >> This changes the vTPM shared page ABI from a copy of the Xen network >> interface to a single-page interface that better reflects the expected >> behavior of a TPM: only a single request packet can be sent at any given >> time, and every packet sent generates a single response packet. > > What tree is this based on? This is based off of Matthew Fioravante's latest xen-tpmfront.ko patch: http://lists.xen.org/archives/html/xen-devel/2012-11/msg01041.html To build on kernel 3.8, this patch needs __devexit references removed (as below); I assume this will be addressed when the other issues you raised when reviewing that patch are fixed. --- diff --git a/drivers/char/tpm/xen-tpmfront_if.c b/drivers/char/tpm/xen-tpmfront_if.c index ba7fad8..649aee6 100644 --- a/drivers/char/tpm/xen-tpmfront_if.c +++ b/drivers/char/tpm/xen-tpmfront_if.c @@ -395,7 +395,7 @@ static int tpmfront_probe(struct xenbus_device *dev, } -static int __devexit tpmfront_remove(struct xenbus_device *dev) +static int tpmfront_remove(struct xenbus_device *dev) { struct tpm_private *tp = tpm_private_from_dev(&dev->dev); destroy_tpmring(tp); @@ -464,7 +464,7 @@ MODULE_ALIAS("xen:vtpm"); static DEFINE_XENBUS_DRIVER(tpmfront, , .probe = tpmfront_probe, - .remove = __devexit_p(tpmfront_remove), + .remove = tpmfront_remove, .resume = tpmfront_resume, .otherend_changed = backend_changed, .suspend = tpmfront_suspend,