From: Marek Marczykowski <marmarek@invisiblethingslab.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/2] libxl: Introduce functions to add and remove host USB devices to an HVM guest
Date: Fri, 22 Mar 2013 17:16:02 +0100 [thread overview]
Message-ID: <514C83C2.4050608@invisiblethingslab.com> (raw)
In-Reply-To: <20809.65387.657743.334820@mariner.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1749 bytes --]
On 20.03.2013 19:26, Ian Jackson wrote:
> George Dunlap writes ("Re: [Xen-devel] [PATCH 1/2] libxl: Introduce functions to add and remove host USB devices to an HVM guest"):
>> There are some semantic differences that I think are important (or could
>> be important). One big one is that PVUSB appears to require the caller
>> to specify the virtual topology used, while with qemu it is not possible
>> to specify the virtual topology. This gives us a few options for a
>> unified interface:
>
> The obvious answer to this is to make specifying the virtual topology
> optional in the unified syntax.
>
> (TBH I'm not sure why anyone would ever want to specify a particular
> virtual topology. I'm sure most people would prefer just to let the
> tools set something up.)
Yes, specifying topology by hand (which basically means creating one USB 1.1
bus and one USB 2.0 bus) is only inconvenience in PVUSB. It should be done
automatically.
>> PVUSB also (it seems) requires devices to be assigned to usbback before
>> they can be given to guests. So in the pv case, device_add() would have
>> to do assign then attach, and device_del would have to do detach then
>> de-assign. That's probably not so bad.
>
> I definitely think this should happen automatically.
Indeed. This is one/two writes to sysfs. One possible difficulty: backend can
be in some domU instead of dom0, but then IMHO assigning device to usbback can
be left to the user.
But important thing: interface needs to allow specify (optional) backend
domain in addition to device itself (with default to dom0). Same as other
interfaces like block or network.
--
Best Regards / Pozdrawiam,
Marek Marczykowski
Invisible Things Lab
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 553 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2013-03-22 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 12:09 [PATCH 1/2] libxl: Introduce functions to add and remove host USB devices to an HVM guest George Dunlap
2013-03-19 12:09 ` [PATCH 2/2] xl: Add hvm-host-usb-add and hvm-host-usb-del commands George Dunlap
2013-03-19 13:14 ` [PATCH 1/2] libxl: Introduce functions to add and remove host USB devices to an HVM guest Roger Pau Monné
2013-03-19 14:04 ` George Dunlap
2013-03-19 17:55 ` Roger Pau Monné
2013-03-20 11:35 ` George Dunlap
2013-03-20 16:51 ` Ian Jackson
2013-03-20 17:50 ` George Dunlap
2013-03-20 18:26 ` Ian Jackson
2013-03-22 16:16 ` Marek Marczykowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514C83C2.4050608@invisiblethingslab.com \
--to=marmarek@invisiblethingslab.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).