From: Ben Guthro <Benjamin.Guthro@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH] x86/S3: Restore broken vcpu affinity on resume
Date: Tue, 26 Mar 2013 12:58:09 -0400 [thread overview]
Message-ID: <5151D3A1.9030606@citrix.com> (raw)
In-Reply-To: <5151E0E902000078000C8AAC@nat28.tlf.novell.com>
On 03/26/2013 12:54 PM, Jan Beulich wrote:
>
> Looks reasonable to me, minus severe formatting issues (hard
> tabs being the most obvious, but not the only problem).
Thanks for the review - Apologies on the formatting.
Would you prefer I clean up the formatting and re-submit, or would you
prefer to take care of it prior to commit
>
> I don't particularly like the increase of scope for these two, but
> I guess there aren't many alternatives.
Indeed.
My first pass at this only operated on cpupool0, which did not require
this scope increase...but it was pointed out that was probably not
sufficient to be acceptable in a more general solution appropriate to
upstream.
Thanks
Ben
next prev parent reply other threads:[~2013-03-26 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 16:12 [PATCH] x86/S3: Restore broken vcpu affinity on resume Ben Guthro
2013-03-26 16:54 ` Jan Beulich
2013-03-26 16:58 ` Ben Guthro [this message]
2013-03-26 17:04 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2013-03-26 17:20 Ben Guthro
2013-03-26 17:23 ` Ben Guthro
2013-03-27 6:06 ` Juergen Gross
2013-03-27 9:19 ` Jan Beulich
2013-03-27 12:01 ` George Dunlap
2013-03-27 12:04 ` Ben Guthro
2013-03-27 12:06 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5151D3A1.9030606@citrix.com \
--to=benjamin.guthro@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).