From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Guthro Subject: Re: [PATCH] x86/S3: Restore broken vcpu affinity on resume Date: Tue, 26 Mar 2013 12:58:09 -0400 Message-ID: <5151D3A1.9030606@citrix.com> References: <1364314352-20280-1-git-send-email-benjamin.guthro@citrix.com> <5151E0E902000078000C8AAC@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5151E0E902000078000C8AAC@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 03/26/2013 12:54 PM, Jan Beulich wrote: > > Looks reasonable to me, minus severe formatting issues (hard > tabs being the most obvious, but not the only problem). Thanks for the review - Apologies on the formatting. Would you prefer I clean up the formatting and re-submit, or would you prefer to take care of it prior to commit > > I don't particularly like the increase of scope for these two, but > I guess there aren't many alternatives. Indeed. My first pass at this only operated on cpupool0, which did not require this scope increase...but it was pointed out that was probably not sufficient to be acceptable in a more general solution appropriate to upstream. Thanks Ben