From mboxrd@z Thu Jan  1 00:00:00 1970
From: konrad wilk <konrad.wilk@oracle.com>
Subject: Re: High CPU temp, suspend problem - xen 4.1.5-pre,
 linux 3.7.x
Date: Mon, 15 Apr 2013 19:51:43 -0400
Message-ID: <516C928F.9010205@oracle.com>
References: <5140E69F.9090803@invisiblethingslab.com>
	<20130322165651.GA4827@phenom.dumpdata.com>
	<515036BF.10105@invisiblethingslab.com>
	<20130325141701.GI11546@phenom.dumpdata.com>
	<515191CC.6060609@invisiblethingslab.com>
	<5151AC8C02000078000C88B9@nat28.tlf.novell.com>
	<5151A788.809@invisiblethingslab.com>
	<5151D4CC02000078000C8A1C@nat28.tlf.novell.com>
	<5151D0A9.7070100@invisiblethingslab.com>
	<5151D49C.2000809@citrix.com>
	<5151DE1C.1020307@invisiblethingslab.com>
	<5151E0D5.3050707@citrix.com>
	<5151E72D.30205@invisiblethingslab.com>
	<5151EE0B.9030605@citrix.com>
	<5152C16E02000078000C8CB8@nat28.tlf.novell.com>
	<515302C3.3000607@invisiblethingslab.com>
	<51547A5302000078000C962C@nat28.tlf.novell.com>
	<515493F0.6030708@invisiblethingslab.com>
	<CAOvdn6Vu_p-_p2etPqMD95pL+iCVVOhfj+51T9jkE=zzGArrAQ@mail.gmail.com>
	<515A30D4.90003@invisiblethingslab.com>
	<516C7AB2.8050406@invisiblethingslab.com>
	<CAOvdn6UgX_ZvR_-U6MXCoLW9jHFy19k=oaF=mZgz_HBGoJDEvw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAOvdn6UgX_ZvR_-U6MXCoLW9jHFy19k=oaF=mZgz_HBGoJDEvw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ben Guthro <ben@guthro.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Marek Marczykowski <marmarek@invisiblethingslab.com>, Jan Beulich <JBeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org


>> 3. ACPI C-states are only present for CPU0 (after resume of course), fixed by
>> "xen: Re-upload processor PM data to hypervisor after S3" patch by Ben, but it
>> isn't in upstream linux (nor Konrad's acpi-s3 branches).
> I don't recall seeing any ACK / NAK from Konrad on this.
>
> Original post:
> https://patchwork.kernel.org/patch/2033981/
>
> Konrad - do you have any thoughts about incorporating this into a
> future merge window?

Hey Ben,
I seem to have missed it.
I think the patch is missing a change to pr_backup->acpi_id = i, 
otherwise it would resend
the C-states with the same APIC ID. Also the upstream version does 
kfree(pr_backup) at some point.

But more importantly, do you know why it is needed? Is Xen hypervisor 
"loosing" this information because they go offline and then they are 
onlined again?