xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"Tim (Xen.org)" <tim@xen.org>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH v3 04/13] xen/arm: support for guest SGI
Date: Fri, 26 Apr 2013 12:46:21 +0100	[thread overview]
Message-ID: <517A690D.2050308@citrix.com> (raw)
In-Reply-To: <1366967103.3142.43.camel@zakaz.uk.xensource.com>

On 04/26/2013 10:05 AM, Ian Campbell wrote:

> On Thu, 2013-04-25 at 20:03 +0100, Julien Grall wrote:
>> On 04/24/2013 08:07 PM, Stefano Stabellini wrote:
>>
>>> +                    break;
>>> +                default:
>>> +                    printk("vGICD: unhandled GICD_SGIR write %x with wrong TargetListFilter field\n", *r);
>>
>> The type of r is register_t, which is equal to u64 on arm64 and u32 on
>> arm32. You should use PRIregister.
> 
> This is true, I expect it breaks compile on arm64?

Right.

> The cross compiler I use is at
> http://www.linaro.org/engineering/armv8/#tab3
> I've got gcc-linaro-aarch64-linux-gnu-4.7-2013.01-20130125_linux but no
> reason why 2013.04 shouldn't also work (I've not tried the 4.8 which I
> see has appeared there now)

I tried the lasted, so the 4.8, the compilation works. For the moment I
haven't tried to boot xen.

Julien

  reply	other threads:[~2013-04-26 11:46 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24 19:06 [PATCH v3 0/13] xen/arm: guest SMP support Stefano Stabellini
2013-04-24 19:07 ` [PATCH v3 01/13] xen/arm: basic PSCI support, implement cpu_on and cpu_off Stefano Stabellini
2013-04-25  9:53   ` Ian Campbell
2013-04-25 10:57     ` Stefano Stabellini
2013-04-25 11:31       ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 02/13] xen/arm: allocate secondaries dom0 vcpus Stefano Stabellini
2013-04-25 10:08   ` Ian Campbell
2013-04-26 13:23     ` Stefano Stabellini
2013-04-26 13:25       ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 03/13] xen: introduce cpumask_from_bitmap Stefano Stabellini
2013-04-25  9:24   ` Jan Beulich
2013-04-25 10:01     ` Ian Campbell
2013-04-25 14:26       ` Keir Fraser
2013-04-25 14:42         ` Ian Campbell
2013-04-25 14:44           ` Ian Campbell
2013-04-25 14:51             ` Ian Campbell
2013-04-25 15:13               ` Keir Fraser
2013-04-25 15:23                 ` Ian Campbell
2013-04-25 17:20                   ` Keir Fraser
2013-04-25 15:08             ` Stefano Stabellini
2013-04-25 15:17               ` Keir Fraser
2013-04-25 15:18               ` Jan Beulich
2013-04-25 15:17             ` Jan Beulich
2013-04-25 10:01     ` Stefano Stabellini
2013-04-25 10:08       ` Jan Beulich
2013-04-25 10:35         ` Stefano Stabellini
2013-04-25 10:49           ` Jan Beulich
2013-04-25 11:38             ` Stefano Stabellini
2013-04-25 12:49               ` Jan Beulich
2013-04-25 14:27                 ` Keir Fraser
2013-04-24 19:07 ` [PATCH v3 04/13] xen/arm: support for guest SGI Stefano Stabellini
2013-04-25 10:16   ` Ian Campbell
2013-04-25 19:03   ` Julien Grall
2013-04-26  9:05     ` Ian Campbell
2013-04-26 11:46       ` Julien Grall [this message]
2013-04-26 12:12   ` Sander Bogaert
2013-04-26 13:07     ` Stefano Stabellini
2013-04-26 13:24     ` Ian Campbell
2013-04-26 13:35       ` Julien Grall
2013-04-26 13:56         ` Sander Bogaert
2013-04-26 14:10           ` Ian Campbell
2013-04-26 13:28     ` Julien Grall
2013-04-24 19:07 ` [PATCH v3 05/13] xen/arm: early_ioremap: allocate virtual addresses from top to bottom Stefano Stabellini
2013-04-25 10:27   ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 06/13] xen/arm: implement arch_vmap_virt_end Stefano Stabellini
2013-04-25 10:29   ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 07/13] xen/arm: compile and initialize vmap Stefano Stabellini
2013-04-25 10:41   ` Ian Campbell
2013-04-25 17:04     ` Stefano Stabellini
2013-04-26  9:00       ` Ian Campbell
2013-04-26 12:02         ` Stefano Stabellini
2013-04-26 13:21           ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 08/13] xen/arm: implement map_domain_page_global and unmap_domain_page_global Stefano Stabellini
2013-04-25 10:43   ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 09/13] xen: move VCPUOP_register_vcpu_info to common code Stefano Stabellini
2013-04-25 10:45   ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 10/13] xen/arm: support VCPUOP_register_vcpu_info Stefano Stabellini
2013-04-25 10:50   ` Ian Campbell
2013-04-25 11:38     ` Stefano Stabellini
2013-04-25 11:40       ` Ian Campbell
2013-04-25 11:41         ` Stefano Stabellini
2013-04-25 14:29       ` Keir Fraser
2013-04-25 14:39         ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 11/13] xen/arm: send IPIs to inject irqs into guest vcpus running on different pcpus Stefano Stabellini
2013-04-25 11:00   ` Ian Campbell
2013-04-26 13:39     ` Stefano Stabellini
2013-04-26 14:08       ` Ian Campbell
2013-04-24 19:07 ` [PATCH v3 12/13] xen/arm: start the vtimer Xen timers on the processor they should be running on Stefano Stabellini
2013-04-25 11:03   ` Ian Campbell
2013-04-26 14:30     ` Stefano Stabellini
2013-04-26 14:35       ` Ian Campbell
2013-04-26 14:36         ` Stefano Stabellini
2013-04-24 19:07 ` [PATCH v3 13/13] xen/arm: initialize virt_timer and phys_timer with the same values on all vcpus Stefano Stabellini
2013-04-25 11:21   ` Ian Campbell
2013-04-26 14:30     ` Stefano Stabellini
2013-04-26 14:37       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517A690D.2050308@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).