From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 04/13] xen/arm: support for guest SGI Date: Fri, 26 Apr 2013 12:46:21 +0100 Message-ID: <517A690D.2050308@citrix.com> References: <1366830463-12153-4-git-send-email-stefano.stabellini@eu.citrix.com> <51797E0D.7080906@citrix.com> <1366967103.3142.43.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1366967103.3142.43.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xensource.com" , "Tim (Xen.org)" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 04/26/2013 10:05 AM, Ian Campbell wrote: > On Thu, 2013-04-25 at 20:03 +0100, Julien Grall wrote: >> On 04/24/2013 08:07 PM, Stefano Stabellini wrote: >> >>> + break; >>> + default: >>> + printk("vGICD: unhandled GICD_SGIR write %x with wrong TargetListFilter field\n", *r); >> >> The type of r is register_t, which is equal to u64 on arm64 and u32 on >> arm32. You should use PRIregister. > > This is true, I expect it breaks compile on arm64? Right. > The cross compiler I use is at > http://www.linaro.org/engineering/armv8/#tab3 > I've got gcc-linaro-aarch64-linux-gnu-4.7-2013.01-20130125_linux but no > reason why 2013.04 shouldn't also work (I've not tried the 4.8 which I > see has appeared there now) I tried the lasted, so the 4.8, the compilation works. For the moment I haven't tried to boot xen. Julien