From: Marek Marczykowski <marmarek@invisiblethingslab.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>,
"Keir (Xen.org)" <keir@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v3] Try to use git commit id if hg changeset is unavailable
Date: Wed, 08 May 2013 21:16:04 +0200 [thread overview]
Message-ID: <518AA474.6050906@invisiblethingslab.com> (raw)
In-Reply-To: <1368027942.17285.38.camel@zakaz.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 835 bytes --]
On 08.05.2013 17:45, Ian Campbell wrote:
> On Wed, 2013-05-08 at 16:15 +0100, Marek Marczykowski wrote:
>> As Xen uses git as primary repository, get git commit id for
>> xen_changeset info.
>>
>> Changes in v2:
>> - split scm calls into separate script - based on Linux kernel one,
>> with tags handling removed
>>
>> Changes in v3:
>> - do not assume tools/scmversion started from the repository toplevel
>> dir - it is actually called from xen/ subdir
>
> I see you did this by removing various checks for .hg and .igt
> directories, but this seems a little fragile and doesn't cover
> the .scmversion case properly.
>
> The scmversion script already takes an optional source dir, why not just
> pass $(XEN_ROOT) ?
Indeed, good idea.
--
Best Regards,
Marek Marczykowski
Invisible Things Lab
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 555 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-05-08 19:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 15:15 [PATCH v3] Try to use git commit id if hg changeset is unavailable Marek Marczykowski
2013-05-08 15:45 ` Ian Campbell
2013-05-08 19:16 ` Marek Marczykowski [this message]
2013-05-08 23:07 ` [PATCH v4] Use {git, hg, svn} commit id if available for xen_changeset Marek Marczykowski
2013-05-10 13:29 ` Ian Campbell
2013-05-10 13:33 ` Andrew Cooper
2013-05-13 9:49 ` Ian Campbell
2013-05-13 11:43 ` Keir Fraser
2013-05-13 11:52 ` Ian Campbell
2013-05-13 13:39 ` Ian Campbell
2013-05-13 13:52 ` [PATCH v3] Try to use git commit id if hg changeset is unavailable Olaf Hering
2013-05-13 18:22 ` Marek Marczykowski
2013-05-13 18:23 ` [PATCH] Cleanup scmversion script, fix --save-scmversion option Marek Marczykowski
2013-05-14 8:50 ` Ian Campbell
2013-07-04 9:56 ` Ian Campbell
2013-07-17 10:36 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518AA474.6050906@invisiblethingslab.com \
--to=marmarek@invisiblethingslab.com \
--cc=Ian.Campbell@citrix.com \
--cc=keir@xen.org \
--cc=linux@eikelenboom.it \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).