From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Marczykowski <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v3] Try to use git commit id if hg changeset
	is unavailable
Date: Wed, 08 May 2013 21:16:04 +0200
Message-ID: <518AA474.6050906@invisiblethingslab.com>
References: <20130508151651.AE77C2AF@duch.mimuw.edu.pl>
	<1368027942.17285.38.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7882362149446535186=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1368027942.17285.38.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>, "Keir (Xen.org)" <keir@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============7882362149446535186==
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="----enig2CBMBWHMQBOWXOXRXFDAH"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2CBMBWHMQBOWXOXRXFDAH
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 08.05.2013 17:45, Ian Campbell wrote:
> On Wed, 2013-05-08 at 16:15 +0100, Marek Marczykowski wrote:
>> As Xen uses git as primary repository, get git commit id for
>> xen_changeset info.
>>
>> Changes in v2:
>>  - split scm calls into separate script - based on Linux kernel one,
>>    with tags handling removed
>>
>> Changes in v3:
>>  - do not assume tools/scmversion started from the repository toplevel=

>>    dir - it is actually called from xen/ subdir
>=20
> I see you did this by removing various checks for .hg and .igt
> directories, but this seems a little fragile and doesn't cover
> the .scmversion case properly.
>=20
> The scmversion script already takes an optional source dir, why not jus=
t
> pass $(XEN_ROOT) ?

Indeed, good idea.

--=20
Best Regards,
Marek Marczykowski
Invisible Things Lab


------enig2CBMBWHMQBOWXOXRXFDAH
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJRiqR1AAoJENuP0xzK19csCv8H/2HkGBKB5g3dTd7WmI43L0p1
Rcu/WRgqKve1Gb2fU9KxclMuRBCijAu1Nbw4gKvOVKEjP/tup8zU8gYgfobd1yR1
jeV/2nKSUEPw30y7PpC0z//r+Nbu1t09wi3XAafL+Q6SwMQa5I3duzOLoU9ZHTAu
E9skLSaph5HqclEAB2cBKNII4r1io5QWhwZ8RXmlZVSnLl8T7KRwAFdij1ohnqIV
X7CXvNd1rZIGCOheZyMTv+sv8Or01Fe/SMatI7zhZbDX3RFZnkYGlugzW26HaOfM
8f6mKf15vPToZDolskiirHxkbGAtttI3SidxT1sFdEKTCZrvtXxtN4itY9dOmWk=
=OpzT
-----END PGP SIGNATURE-----

------enig2CBMBWHMQBOWXOXRXFDAH--


--===============7882362149446535186==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7882362149446535186==--