From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Marczykowski <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v3] Try to use git commit id if hg changeset
 is unavailable
Date: Mon, 13 May 2013 20:22:54 +0200
Message-ID: <51912F7E.20508@invisiblethingslab.com>
References: <20130508151651.AE77C2AF@duch.mimuw.edu.pl>
	<20130513135207.GA20959@aepfle.de>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6026766979460675121=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130513135207.GA20959@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Sander Eikelenboom <linux@eikelenboom.it>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============6026766979460675121==
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="----enig2QVNXRKNWJQFSKIUQGUWV"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2QVNXRKNWJQFSKIUQGUWV
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 13.05.2013 15:52, Olaf Hering wrote:
> On Wed, May 08, Marek Marczykowski wrote:
>=20
>> +scm_version()
>> +{
>> +	local short
>=20
> What is short supposed to do? Looks like a write-only variable.

Some leftover from --short option of kernel script, not used here. But
--save-scmversion option is broken. This should be equivalent for
"xen/tools/scmversion > .scmversion". So either option should be fixed or=

removed completely. I vote for fix and do so in the patch (next email).

--=20
Best Regards,
Marek Marczykowski
Invisible Things Lab


------enig2QVNXRKNWJQFSKIUQGUWV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJRkS9+AAoJENuP0xzK19cspOcH/RGnQek0VbcdTntHB8oCpdcA
/zBW3uQaUt+U7zri4uu/9nAJM114/AKyHARzfcQjRPj00Q+hZYY67QrT5PSryyCS
p/RHjGOAOvTo2g4biC0tPbDIrdCaJk3G7yW8WeAYAP3dnOKmcgdYwatkIUe99nWN
JUb4cr7KZuqT5vwJuZzmVY3ilKlcD7yabPu6aL0TOeOslFJYVXmFuikCoZ2X0Wii
9oeEXT0mDxAxA47xZqEWKhDLc+HzC9/nthtop5zwAysBpQ0Vr4js+bkSGwWN3cq8
v0vJIJngx0HtsaKYMvTTX9IF4zxlnbbQ12C0H4u7LFS00mHeKoJySJ2bSK0QAfw=
=XIOW
-----END PGP SIGNATURE-----

------enig2QVNXRKNWJQFSKIUQGUWV--


--===============6026766979460675121==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6026766979460675121==--