xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Fabio Fantoni <fabio.fantoni@m2r.biz>
Cc: Anthony Perard <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Xen 4.3 development update RC2 imminent
Date: Fri, 24 May 2013 16:52:25 +0100	[thread overview]
Message-ID: <519F8CB9.903@eu.citrix.com> (raw)
In-Reply-To: <519F7EE3.3070603@m2r.biz>


[-- Attachment #1.1: Type: text/plain, Size: 5924 bytes --]

On 24/05/13 15:53, Fabio Fantoni wrote:
> Il 24/05/2013 15:59, George Dunlap ha scritto:
>> On 24/05/13 14:56, Fabio Fantoni wrote:
>>> Il 23/05/2013 18:07, George Dunlap ha scritto:
>>>> On 23/05/13 15:58, Fabio Fantoni wrote:
>>>>> Il 23/05/2013 16:26, George Dunlap ha scritto:
>>>>>> On 23/05/13 15:17, Fabio Fantoni wrote:
>>>>>>> Il 23/05/2013 12:54, George Dunlap ha scritto:
>>>>>>>> On 23/05/13 11:39, Andrew Cooper wrote:
>>>>>>>>> On 23/05/13 11:36, Fabio Fantoni wrote:
>>>>>>>>>> Il 23/05/2013 09:39, Jan Beulich ha scritto:
>>>>>>>>>>>>>> On 22.05.13 at 18:54, George Dunlap 
>>>>>>>>>>>>>> <george.dunlap@eu.citrix.com> wrote:
>>>>>>>>>>>> On 22/05/13 17:30, Pasi Kärkkäinen wrote:
>>>>>>>>>>>>> On Wed, May 22, 2013 at 04:05:27PM +0100, George Dunlap 
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>> Hmm, for testing, can we use cpuid to mask out SSE,
>>>>>>>>>>>>> and then try qxl ?
>>>>>>>>>>>> That had occurred to me -- Andrew / Jan, do you know which 
>>>>>>>>>>>> flag might
>>>>>>>>>>>> disable this particular instruction?
>>>>>>>>>>>>
>>>>>>>>>>>> I guess we could try just disabling all the SSE instructions.
>>>>>>>>>>> movdqu is an SSE2 instruction, so disabling bit 26 of CPUID EDX
>>>>>>>>>>> output to EAX=1 input.
>>>>>>>>>> Can you explain better please?
>>>>>>>>>> Should I add this to test it?
>>>>>>>>>> cpuid="host,sse=0,sse2=0,ssse3=0,sse4_1=0,sse4_2=0,eax=1"
>>>>>>>>> It will likely not work.  SSE2 is an architectural requirement 
>>>>>>>>> for 64bit.
>>>>>>>>>
>>>>>>>>> It means that 64bit code may assume the presence of SSE2.  Xen 
>>>>>>>>> amongst
>>>>>>>>> other software does make this assumption.
>>>>>>>>
>>>>>>>> It might work if he's using 32-bit.
>>>>>>>>
>>>>>>>> Fabio, as I said in my initial e-mail, you need to:
>>>>>>>>
>>>>>>>> 1. Run "cat /proc/cpuinfo" on your dom0
>>>>>>>> 2. Look at the line that says "features:"
>>>>>>>> 3. Find all the things that contain "sse" > 2 (sse2, ssse3, &c)
>>>>>>>> 4. Set them to 0 in the "cpuid" field like above.
>>>>>>>>
>>>>>>>> Every processor will be a bit different -- you can't just copy 
>>>>>>>> mine and expect it to work.
>>>>>>>>
>>>>>>>> Don't include "eax=1" -- Jan is thinking of a different interface.
>>>>>>>>
>>>>>>>>  -George
>>>>>>> Tried with Raring (ubuntu 13.04) 32bit...
>>>>>>> in cfg:
>>>>>>> cpuid="host,sse=0,sse2=0,ssse3=0,sse4_1=0,sse4_2=0"
>>>>>>>
>>>>>>> # xl create /etc/xen/RARING.cfg
>>>>>>> Parsing config from /etc/xen/RARING.cfg
>>>>>>> while parsing CPUID flag: "sse4_1=0":
>>>>>>>   error #2: unknown CPUID flag name
>>>>>>> while parsing CPUID flag: "sse4_2=0":
>>>>>>>   error #2: unknown CPUID flag name
>>>>>>
>>>>>> Right -- in that case this is a minor bug in libxl. (Actually I 
>>>>>> got the same result, I just didn't notice the error messages -- 
>>>>>> sorry about that.)
>>>>>>
>>>>>>>
>>>>>>> In domU:
>>>>>>> # cat /proc/cpuinfo | grep sse
>>>>>>> flags           : fpu vme de pse tsc msr pae mce cx8 apic sep 
>>>>>>> mtrr pge mca cmov
>>>>>>>  pat pse36 clflush mmx fxsr ht nx rdtscp lm constant_tsc pni 
>>>>>>> cx16 *sse4_1 sse4_2* x2apic popcnt tsc_deadline_timer hypervisor 
>>>>>>> lahf_lm
>>>>>>>
>>>>>>> What should I do to have sse4 disabled?
>>>>>>>
>>>>>>> For now with sse, sse2 and sse3 disabled the performance is very 
>>>>>>> very low (even without qxl), while performances are acceptables 
>>>>>>> with SSE.
>>>>>>> I got the same results with qxl card and qxl driver loaded, but 
>>>>>>> now at least X and qemu didn't crash.
>>>>>>
>>>>>> Sorry, same result as what?  Does the X driver work or not?
>>>>> X qxl driver works with sse disabled (tried also with the correct 
>>>>> sse4.1 and sse4.2 on cpuid) but performance are too bad, even 
>>>>> without qxl, therefore it seems that the performance problem is 
>>>>> only due to sse being disabled.
>>>>
>>>> Well that's good news anyway -- it means that qxl as a feature is 
>>>> actually within reach. :-)
>>>>
>>>> Can you try it just with sse2 disabled?
>>> Tried with only sse2 disabled: Raring domU did not complete the O.S. 
>>> loading and qemu did not crash.
>>> Qemu log without error and unable to connect with xl console.
>>> Same result with only sse (1) enabled.
>>> What should I do for debugging in this case with nothing on logs?
>>> Should I recompile qemu with "--enable-debug" and/or should I do 
>>> other things?
>>
>> I don't think these can really be classified as bugs -- it's 
>> perfectly reasonable for software to expect to be running on an 
>> actual processor that someone made; so if you end up setting a CPUID 
>> that doesn't match any real-life processor, and that breaks some 
>> assumptions, I think there's nothing we can really do about that.
>>
>> It was always a long-shot that this "disable sse instructions" thing 
>> would work -- I'm surprised in fact that disabling *all* sse 
>> instructions actually ran, and not at all surprised that the result 
>> was incredibly slow.  But since it's easy to try, there's no harm in 
>> giving it a shot.  Too bad it didn't work out.
>>
>>  -George
> Thanks for all your help.
> Are there other test I can do or only wait for a patch?
> About patch I'm thinking to do fast test by increasing size variable 
> (and connected things) of hvmemul_do_io() function in 
> ...x86/hvm/emulate.c, but if you tell that the patch is very complex 
> probably my idea is only very stupid.
> I also not understand why check if size > of long while size is 
> defined int in that function ( hvmemul_do_io() ), probably is another 
> stupid question.

All I can tell you are that the two options I was going to explore were:
* Increase the size of the "data" element of ioreq_t in 
xen.git/xen/include/public/hvm/ioreq.h
* When you detect size > sizeof(long), switch to data_is_ptr mode.

In the first case you'll need to be sure to re-compile qemu.

I'm afraid I won't be able to give you any more help than that at the 
moment.

  -George


[-- Attachment #1.2: Type: text/html, Size: 10393 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-05-24 15:52 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 10:33 Xen 4.3 development update RC2 imminent George Dunlap
2013-05-20 10:36 ` George Dunlap
2013-05-20 17:12   ` Keir Fraser
2013-05-21  8:13     ` Tim Deegan
2013-05-21 10:22       ` Jan Beulich
2013-05-21  8:19   ` Jan Beulich
2013-05-21  8:22     ` George Dunlap
2013-05-21  8:25       ` Jan Beulich
2013-05-20 10:51 ` Wei Liu
2013-05-20 11:09   ` George Dunlap
2013-05-20 11:16     ` Ian Campbell
2013-05-20 11:32       ` George Dunlap
2013-05-20 11:46         ` Ian Campbell
2013-05-20 13:42           ` George Dunlap
2013-05-20 11:15   ` Ian Campbell
2013-05-20 11:22 ` George Dunlap
2013-05-20 11:26 ` Ian Campbell
2013-05-20 11:28   ` George Dunlap
2013-05-20 11:48     ` Ian Campbell
2013-05-21 14:06 ` Anthony PERARD
2013-05-21 14:31   ` Andrew Cooper
2013-05-21 14:49     ` George Dunlap
2013-05-21 14:55     ` Jan Beulich
2013-05-21 14:58       ` Andrew Cooper
2013-05-21 15:07         ` Jan Beulich
2013-05-21 16:13       ` George Dunlap
2013-05-21 16:16         ` George Dunlap
2013-05-22 12:49           ` Fabio Fantoni
2013-05-22 12:58             ` Andrew Cooper
2013-05-22 15:05             ` George Dunlap
2013-05-22 16:30               ` Pasi Kärkkäinen
2013-05-22 16:54                 ` George Dunlap
2013-05-23  7:39                   ` Jan Beulich
2013-05-23 10:36                     ` Fabio Fantoni
2013-05-23 10:39                       ` Andrew Cooper
2013-05-23 10:54                         ` George Dunlap
2013-05-23 14:17                           ` Fabio Fantoni
2013-05-23 14:26                             ` George Dunlap
2013-05-23 14:35                               ` George Dunlap
2013-05-23 14:58                               ` Fabio Fantoni
2013-05-23 15:10                                 ` Pasi Kärkkäinen
2013-05-23 16:10                                   ` George Dunlap
2013-05-23 16:07                                 ` George Dunlap
2013-05-24 13:56                                   ` Fabio Fantoni
2013-05-24 13:59                                     ` George Dunlap
2013-05-24 14:53                                       ` Fabio Fantoni
2013-05-24 15:52                                         ` George Dunlap [this message]
2013-05-23 14:32                             ` George Dunlap
2013-05-23 10:48                       ` Jan Beulich
2013-05-23 10:31                   ` Fabio Fantoni
2013-05-23 14:01                     ` Pasi Kärkkäinen
2013-05-22 12:48   ` Fabio Fantoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519F8CB9.903@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=fabio.fantoni@m2r.biz \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).