From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 1/3] qemu_chr_new_from_opts: do not overwrite existing chr->filename Date: Tue, 28 May 2013 08:37:15 +0200 Message-ID: <51A4509B.8080109@redhat.com> References: <1369678422-658-1-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1369678422-658-1-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini Cc: aliguori@us.ibm.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, anthony.perard@citrix.com, pbonzini@redhat.com, afaerber@suse.de List-Id: xen-devel@lists.xenproject.org On 05/27/13 20:13, Stefano Stabellini wrote: > Set the new filename only if it hasn't been already set (for example by > qemu_chr_open_pty). > > This fixes a regression that prevents Xen HVM domains from booting. > It was introduced by: > > commit 2b220025993e76d4116781ca91a4fabc5ad9c722 > Author: Lei Li > Date: Tue May 21 18:27:59 2013 +0800 FYI: just posted a pull req which reverts this one (you are cc'ed). cheers, Gerd