From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefano.Stabellini@eu.citrix.com, patches@linaro.org,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm: Rework the way to compute dom0 DTB base address
Date: Tue, 28 May 2013 12:24:28 +0100 [thread overview]
Message-ID: <51A493EC.2010805@linaro.org> (raw)
In-Reply-To: <1369739941.3469.60.camel@zakaz.uk.xensource.com>
On 05/28/2013 12:19 PM, Ian Campbell wrote:
>>>> if ( ret < 0 )
>>>> goto err;
>>>>
>>>> - /*
>>>> - * Put the device tree at the beginning of the first bank. It
>>>> - * must be below 4 GiB.
>>>> - */
>>>> - kinfo->dtb_paddr = kinfo->mem.bank[0].start + 0x100;
>>>> if ( kinfo->dtb_paddr + fdt_totalsize(kinfo->fdt) > (1ull << 32) )
>>>
>>> Isn't this check now misplaced?
>>
>>
>> Right. I think we can remove kinfo->dtb_paddr and just check the DTB
>> size is less than 4GiB.
>
> Is it easy to check for overlap with the kernel and provide a useful
> message in that case?
It's possible :). I will add it in the next version.
--
Julien
prev parent reply other threads:[~2013-05-28 11:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 13:50 [PATCH] xen/arm: Rework the way to compute dom0 DTB base address Julien Grall
2013-05-27 13:58 ` Andrew Cooper
2013-05-27 15:44 ` Julien Grall
2013-05-28 9:05 ` Ian Campbell
2013-05-28 9:03 ` Ian Campbell
2013-05-28 11:11 ` Julien Grall
2013-05-28 11:19 ` Ian Campbell
2013-05-28 11:24 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A493EC.2010805@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=patches@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).