xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	Keir Fraser <keir.xen@gmail.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Fabio Fantoni <fabio.fantoni@m2r.biz>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] libxl: Remove qxl support for the 4.3 release
Date: Wed, 29 May 2013 23:25:36 +0100	[thread overview]
Message-ID: <51A68060.7010500@citrix.com> (raw)
In-Reply-To: <1369813427.22605.38.camel@dagon.hellion.org.uk>

On 29/05/2013 08:43, Ian Campbell wrote:
> On Tue, 2013-05-28 at 19:09 +0100, Keir Fraser wrote:
>> On 28/05/2013 17:51, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:
>>
>>> George Dunlap writes ("[PATCH] libxl: Remove qxl support for the 4.3
>>> release"):
>>>> The qxl drivers for Windows and Linux end up calling instructions
>>>> that cannot be used for MMIO at the moment.  Just for the 4.3 release,
>>>> remove qxl support.
>>>>
>>>> This patch should be reverted as soon as the 4.4 development window opens.
>>>>
>>>> The issue in question:
>>>>
>>>> (XEN) emulate.c:88:d18 bad mmio size 16
>>>> (XEN) io.c:201:d18 MMIO emulation failed @ 0033:7fd2de390430: f3 0f 6f
>>>> 19 41 83 e8 403
>>>>
>>>> The instruction in question is "movdqu (%rcx),%xmm3".  Xen knows how
>>>> to emulate it, but unfortunately %xmm3 is 16 bytes long, and the interface
>>>> between Xen and qemu at the moment would appear to only allow MMIO accesses
>>>> of 8 bytes.
>>>>
>>>> It's too late in the release cycle to find a fix or a workaround.
>>> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>> It could be plumbed through hvmemul_do_io's multi-cycle read/write logic,
>> and done as two 8-byte cycles to qemu. This would avoid bloating the ioreq
>> structure that communicates to qemu.
> Are you proposing we do this for 4.3? I'm not sure how big that change
> would be in terms of impact (just that one instruction, any 16 byte
> operand?).
>
> Of course even if we did this for 4.3 we don't know what the next issue
> will be with QXL.
>
> Ian.

Furthermore, AVX instruction emulation would require support for 32byte
operands.  I don't see the multi-cycle logic scaling sensibly.

~Andrew

>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

  reply	other threads:[~2013-05-29 22:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24 15:20 [PATCH] libxl: Remove qxl support for the 4.3 release George Dunlap
2013-05-28 16:51 ` Ian Jackson
2013-05-28 18:09   ` Keir Fraser
2013-05-29  7:43     ` Ian Campbell
2013-05-29 22:25       ` Andrew Cooper [this message]
2013-07-05 16:59         ` George Dunlap
2013-09-16 14:10           ` Fabio Fantoni
2013-09-16 14:28             ` Jan Beulich
2013-09-16 14:49               ` Fabio Fantoni
2013-05-29 10:24     ` George Dunlap
2013-05-30  8:57   ` Ian Campbell
2013-05-29 15:01 ` George Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2013-09-18  8:07 Jan Beulich
2013-09-18 12:29 ` Fabio Fantoni
2013-09-18 12:42   ` Jan Beulich
2013-09-18 14:12     ` Fabio Fantoni
2013-09-18 14:30       ` Jan Beulich
2013-09-18 15:26         ` Fabio Fantoni
     [not found]         ` <5239C616.8000507@m2r.biz>
2013-09-18 15:35           ` Jan Beulich
     [not found]           ` <5239E46802000078000F4764@nat28.tlf.novell.com>
2013-09-19  9:22             ` Fabio Fantoni
     [not found]             ` <523AC243.1050406@m2r.biz>
2013-09-19 10:01               ` Jan Beulich
     [not found]               ` <523AE7AB02000078000F4A15@nat28.tlf.novell.com>
2013-09-19 10:04                 ` George Dunlap
     [not found]                 ` <523ACC26.6030307@eu.citrix.com>
2013-09-19 11:08                   ` Fabio Fantoni
2013-09-19 10:09 ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A68060.7010500@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=fabio.fantoni@m2r.biz \
    --cc=keir.xen@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).