From: Julien Grall <julien.grall@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: patches@linaro.org, xen-devel@lists.xen.org,
Ian Campbell <Ian.Campbell@citrix.com>,
Stefano.Stabellini@eu.citrix.com
Subject: Re: [PATCH v2 1/2] xen/arm: Rework the way to compute dom0 DTB base address
Date: Fri, 31 May 2013 14:45:25 +0100 [thread overview]
Message-ID: <51A8A975.2000800@citrix.com> (raw)
In-Reply-To: <51A8A58E.9090501@linaro.org>
On 05/31/2013 02:28 PM, Julien Grall wrote:
>>> + if ( !(MAX(zimage_start, dtb_end) < MIN(zimage_end, dtb_start)) )
>>> + return 0;
>>
>> I had to draw quite a few pictures to convince myself this was right,
>> and I'm still not entirely sure ;-)
>
>
> In fact it's totally wrong :/. What about this check?
>
Another mistake on the first check:
if ( (dtb_start > zimage_end) || (dtb_end < zimage_start) )
--
Julien
next prev parent reply other threads:[~2013-05-31 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 14:05 [PATCH v2 0/2] Rework the way to compute dom0 DTB base address Julien Grall
2013-05-30 14:05 ` [PATCH v2 1/2] xen/arm: " Julien Grall
2013-05-31 11:45 ` Ian Campbell
2013-05-31 13:28 ` Julien Grall
2013-05-31 13:45 ` Julien Grall [this message]
2013-05-31 14:14 ` Ian Campbell
2013-05-30 14:05 ` [PATCH v2 2/2] xen/arm: If the DOM0 zImage as a DTB appended replace it Julien Grall
2013-05-30 14:24 ` Ian Campbell
2013-05-30 14:47 ` Julien Grall
2013-05-30 14:52 ` Ian Campbell
2013-05-30 15:01 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A8A975.2000800@citrix.com \
--to=julien.grall@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=julien.grall@linaro.org \
--cc=patches@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).