From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Keir Fraser <keir@xen.org>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] x86/vtsc: update vcpu_time after hvm_set_guest_time
Date: Tue, 4 Jun 2013 14:48:23 +0200 [thread overview]
Message-ID: <51ADE217.2030405@citrix.com> (raw)
In-Reply-To: <51ADEF9002000078000DB11E@nat28.tlf.novell.com>
On 04/06/13 13:45, Jan Beulich wrote:
>>>> On 04.06.13 at 13:15, Roger Pau Monné<roger.pau@citrix.com> wrote:
>> On 04/06/13 11:47, George Dunlap wrote:
>>> You could gate calling update_vcpu_system_time on:
>>> 1. Whether stime_offset actually changed
>>> 2. Whether v is currently running
>>
>> I'm not sure if only updating the vcpu time if the vCPU is running can
>> lead to a slip in the vcpu time update. As an example, if we call
>> hvm_set_guest_time with the vCPU not running and change the offset, and
>> then call it again on resume, but the offset has not changed this time
>> the vcpu time will not be updated.
>
> But in that case the call from context_switch() would take care
> of it, wouldn't it?
Sure, I just got messed up with what we discussed before about gating
the call to update_vcpu_system_time in context_switch for the HVM case.
Will resend shortly.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-06-04 12:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 9:10 [PATCH] x86/vtsc: update vcpu_time after hvm_set_guest_time Roger Pau Monne
2013-06-04 9:24 ` Jan Beulich
2013-06-04 9:46 ` Roger Pau Monné
2013-06-04 9:56 ` George Dunlap
2013-06-04 10:41 ` Jan Beulich
2013-06-04 9:47 ` George Dunlap
2013-06-04 9:58 ` Roger Pau Monné
2013-06-04 10:00 ` George Dunlap
2013-06-04 10:12 ` Roger Pau Monné
2013-06-04 11:15 ` Roger Pau Monné
2013-06-04 11:45 ` Jan Beulich
2013-06-04 12:48 ` Roger Pau Monné [this message]
2013-06-04 10:24 ` Alex Bligh
2013-06-04 10:28 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADE217.2030405@citrix.com \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).