From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: Is: events not being cleared during fast migration
 over InfiniBand Was: Re: xen 4.3 test report
Date: Thu, 6 Jun 2013 10:23:59 +0100
Message-ID: <51B0552F.1020307@eu.citrix.com>
References: <CACaajQvhhC4VH8=YoMegGXLWQ0mnCiaENWZ-EDfjCTqNgfZHsA@mail.gmail.com>
	<CAFLBxZYxOyVZm+G-SU8EZdi4yi+eA6RN4-nZuo8DxDPyhiE-=Q@mail.gmail.com>
	<20130524141150.GA3900@phenom.dumpdata.com>
	<CAFLBxZa2CCL9OtE5=D0Kg5e1HuiX=ib5iFj-vP=ghewBnwMyBg@mail.gmail.com>
	<CACaajQuZC+HDgkx-gfg=8S2n95z2fHuGYrNPe+rfCB7W1e5V0w@mail.gmail.com>
	<20130525114058.GH2418@localhost.localdomain>
	<CACaajQvAxOCCc-=sGm_ZCf+Z8w__o2f3+wD9obRKZjOK98kQfw@mail.gmail.com>
	<20130603140837.GP6893@phenom.dumpdata.com>
	<CACaajQt2p-o8+obQzW_hqUoxp0KnBLf1GmO0-4GySpeEp+nrLg@mail.gmail.com>
	<20130605185005.GA15558@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130605185005.GA15558@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 05/06/13 19:50, Konrad Rzeszutek Wilk wrote:
> On Tue, Jun 04, 2013 at 04:17:55PM +0400, Vasiliy Tolstov wrote:
>> 2013/6/3 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>:
>>> The non-debug version tells me it is:
>>>
>>> 289     if ( (port = get_free_port(d)) < 0 )
>>> 290         ERROR_EXIT(port);
>>>
>>> Which gets -EEXIST from get_free_port. But get_free_port only returns
>>> -EINVAL, -ENOMEM, and -ENOSPC in failure modes.
>>>
>>> But we get -EEXIST? Could you re-run git diff and attach output to
>>> this email? I think you tweaked the debug code a bit so I am looking
>>> at something different?
>>
>> Oh sorry. Yes i modify you patch to this version:
> That is OK.
>> -    if ( v->virq_to_evtchn[virq] != 0 )
>> +    if ( v->virq_to_evtchn[virq] != 0 ) {
>> +       gdprintk(XENLOG_WARNING, "d%dv%d [%s:%d], port:%d, rc:%ld\n",
>> d->domain_id,
>> +               vcpu, __func__,__LINE__, v->virq_to_evtchn[virq],
>> (long)-EEXIST);
>>           ERROR_EXIT(-EEXIST);
> OK, so the value was 3 (event channel), and I am not sure what the virq value
> was. But it looks as if somebody did not clear that and we are
> tripping over it.
>
> George, have you seen issues with events not being cleared during migration?

I haven't, no.  Do you know where the virq is supposed to be clear? The 
BUG() is in restore_cpu_virqs(), but at a quick glance I can't find a 
corresponding function to tear down virqs.

  -George